-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7259: README.md should mention that the build script works for Mac OS #251
Conversation
👋 Welcome back gunnarmorling! A progress list of the required criteria for merging this PR into |
@thegreystone That's a quick one to review ;) |
@gunnarmorling This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/sponsor |
@thegreystone The change author (@gunnarmorling) must issue an |
/integrate
… |
@gunnarmorling |
/sponsor |
@thegreystone @gunnarmorling Pushed as commit b273c96. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Found that the build.sh script works on macOS, too.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/251/head:pull/251
$ git checkout pull/251
Update a local copy of the PR:
$ git checkout pull/251
$ git pull https://git.openjdk.java.net/jmc pull/251/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 251
View PR using the GUI difftool:
$ git pr show -t 251
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/251.diff