Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMC-7258: Use the public XLST classes for the release notes #252

Closed
wants to merge 2 commits into from

Conversation

reinhapa
Copy link
Member

@reinhapa reinhapa commented May 27, 2021

Signed-off-by: Patrick Reinhart patrick@reini.net


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7258: Use the public XLST classes for the release notes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/252/head:pull/252
$ git checkout pull/252

Update a local copy of the PR:
$ git checkout pull/252
$ git pull https://git.openjdk.java.net/jmc pull/252/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 252

View PR using the GUI difftool:
$ git pr show -t 252

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/252.diff

Signed-off-by: Patrick Reinhart <patrick@reini.net>
@bridgekeeper
Copy link

bridgekeeper bot commented May 27, 2021

👋 Welcome back reinhapa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 27, 2021
@mlbridge
Copy link

mlbridge bot commented May 27, 2021

Webrevs

Signed-off-by: Patrick Reinhart <patrick@reini.net>
@openjdk
Copy link

openjdk bot commented May 27, 2021

@reinhapa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7258: Use the public XLST classes for the release notes

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • b273c96: 7259: README.md should mention that the build script works for Mac OS

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label May 27, 2021
@reinhapa
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor label May 27, 2021
@openjdk
Copy link

openjdk bot commented May 27, 2021

@reinhapa
Your change (at version 32657ec) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented May 28, 2021

@thegreystone @reinhapa Since your change was applied there has been 1 commit pushed to the master branch:

  • b273c96: 7259: README.md should mention that the build script works for Mac OS

Your commit was automatically rebased without conflicts.

Pushed as commit 6478ba9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@reinhapa reinhapa deleted the jmc7258 branch May 28, 2021 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants