Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7261: Enhance agent pom.xml for future library deployment #253

Closed
wants to merge 1 commit into from

Conversation

reinhapa
Copy link
Member

@reinhapa reinhapa commented May 27, 2021

Signed-off-by: Patrick Reinhart patrick@reini.net


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7261: Enhance agent pom.xml for future library deployment

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/253/head:pull/253
$ git checkout pull/253

Update a local copy of the PR:
$ git checkout pull/253
$ git pull https://git.openjdk.java.net/jmc pull/253/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 253

View PR using the GUI difftool:
$ git pr show -t 253

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/253.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 27, 2021

👋 Welcome back reinhapa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 27, 2021
@mlbridge
Copy link

mlbridge bot commented May 27, 2021

Webrevs

@thegreystone thegreystone requested a review from guruhb May 27, 2021 20:02
Signed-off-by: Patrick Reinhart <patrick@reini.net>
@thegreystone thegreystone changed the title JMC-7261: Enhance agent pom.xml for future library deployment 7261: Enhance agent pom.xml for future library deployment May 28, 2021
Copy link
Contributor

@guruhb guruhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@openjdk
Copy link

openjdk bot commented Jun 2, 2021

@reinhapa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7261: Enhance agent pom.xml for future library deployment

Reviewed-by: ghb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@guruhb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jun 2, 2021
@reinhapa
Copy link
Member Author

reinhapa commented Jun 2, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jun 2, 2021
@openjdk
Copy link

openjdk bot commented Jun 2, 2021

@reinhapa
Your change (at version 39037f4) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

/sponsor

@openjdk openjdk bot closed this Jun 2, 2021
@openjdk
Copy link

openjdk bot commented Jun 2, 2021

@thegreystone @reinhapa Pushed as commit 7220aee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@reinhapa reinhapa deleted the jmc7261 branch June 9, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants