Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7262: Add rule for when the JVM version is < OpenJDK 8u302 #256

Closed

Conversation

ojung
Copy link
Contributor

@ojung ojung commented Jun 1, 2021

This PR contains a rule for notifying users of JVM < OpenJDK8u302 to upgrade to avoid performance issues caused by https://bugs.openjdk.java.net/browse/JDK-8266723.

JFR recorded on OpenJDK 8u302 EA:
Screen Shot 2021-06-02 at 14 45 46

JFR recorded on OpenJDK 8u292:
Screen Shot 2021-06-02 at 15 49 14


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7262: Add rule for when the JVM version is < OpenJDK 8u302

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/256/head:pull/256
$ git checkout pull/256

Update a local copy of the PR:
$ git checkout pull/256
$ git pull https://git.openjdk.java.net/jmc pull/256/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 256

View PR using the GUI difftool:
$ git pr show -t 256

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/256.diff

@bridgekeeper bridgekeeper bot added the oca label Jun 1, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 1, 2021

Hi @ojung, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ojung" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@bridgekeeper bridgekeeper bot removed the oca label Jun 1, 2021
@thegreystone
Copy link
Member

Don't worry about the translations - translation drops will eventually be provided by Oracle.

@ojung ojung changed the title Add rule for periodic events performance issue 7262: Add rule for when the JVM version is < OpenJDK 8u302 Jun 2, 2021
@ojung ojung force-pushed the 7262-add-jfr-periodic-events-fix-rule branch 2 times, most recently from 252ba2d to 08f81ae Compare June 2, 2021 12:40
@ojung
Copy link
Contributor Author

ojung commented Jun 2, 2021

/covered

@ojung ojung marked this pull request as ready for review June 2, 2021 12:41
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 2, 2021

You are already a known contributor!

@openjdk openjdk bot added the rfr label Jun 2, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 2, 2021

Webrevs

Copy link
Collaborator

@bric3 bric3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks, but it seems good!

@ojung ojung force-pushed the 7262-add-jfr-periodic-events-fix-rule branch from 08f81ae to 247db81 Compare June 2, 2021 13:50
@ojung
Copy link
Contributor Author

ojung commented Jun 2, 2021

Hey @bric3, thanks for your comments! Unfortunately I didn't notice you already started reviewing. I force-pushed a rewritten commit. The difference is, that I now check if it is an OpenJDK. See https://github.com/openjdk/jmc/pull/256/files#diff-d03e56fffa9483fb8054f457e45a52a76c057012d19c9d68ec88926db8a0624fR83-R85

@ojung ojung force-pushed the 7262-add-jfr-periodic-events-fix-rule branch from 6bfbe58 to ec8c647 Compare June 2, 2021 15:06
@thegreystone thegreystone self-requested a review June 2, 2021 15:29
ojung added 3 commits June 2, 2021 18:15
Since the test flight recording was created with 8u302 EA, a method
`JavaVersion.isGreaterOrEqualThanDisregardEa` had to be added to compare
java versions disregarding early access status.
@ojung ojung force-pushed the 7262-add-jfr-periodic-events-fix-rule branch from ec8c647 to 8a89564 Compare June 2, 2021 16:16
@thegreystone
Copy link
Member

@ojung - there is no need to force push new editions of the branch. You can have one gazillion commits in the PR; In the end Skara will squish them into one commit when integrating anyways. :)

@openjdk
Copy link

openjdk bot commented Jun 2, 2021

@ojung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7262: Add rule for when the JVM version is < OpenJDK 8u302

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 8c28f1b: 7260: Create a new serializers bundle
  • 103245e: 7060: [WLS] Rule result formatting update w.r.t Rule 2.0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone, @Gunde) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jun 2, 2021
@ojung
Copy link
Contributor Author

ojung commented Jun 2, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jun 2, 2021
@openjdk
Copy link

openjdk bot commented Jun 2, 2021

@ojung
Your change (at version 0ceef2d) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

/sponsor

@openjdk openjdk bot closed this Jun 2, 2021
@openjdk
Copy link

openjdk bot commented Jun 2, 2021

@thegreystone @ojung Since your change was applied there have been 2 commits pushed to the master branch:

  • 8c28f1b: 7260: Create a new serializers bundle
  • 103245e: 7060: [WLS] Rule result formatting update w.r.t Rule 2.0

Your commit was automatically rebased without conflicts.

Pushed as commit f2e80e7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants