-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7262: Add rule for when the JVM version is < OpenJDK 8u302 #256
Conversation
Hi @ojung, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ojung" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
Don't worry about the translations - translation drops will eventually be provided by Oracle. |
252ba2d
to
08f81ae
Compare
/covered |
You are already a known contributor! |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks, but it seems good!
core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/version/JavaVersion.java
Outdated
Show resolved
Hide resolved
...ain/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties
Outdated
Show resolved
Hide resolved
08f81ae
to
247db81
Compare
Hey @bric3, thanks for your comments! Unfortunately I didn't notice you already started reviewing. I force-pushed a rewritten commit. The difference is, that I now check if it is an |
6bfbe58
to
ec8c647
Compare
...src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/JfrPeriodicEventsFixRule.java
Show resolved
Hide resolved
...src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/JfrPeriodicEventsFixRule.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/JfrPeriodicEventsFixRule.java
Outdated
Show resolved
Hide resolved
Since the test flight recording was created with 8u302 EA, a method `JavaVersion.isGreaterOrEqualThanDisregardEa` had to be added to compare java versions disregarding early access status.
ec8c647
to
8a89564
Compare
@ojung - there is no need to force push new editions of the branch. You can have one gazillion commits in the PR; In the end Skara will squish them into one commit when integrating anyways. :) |
...rg.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/version/JavaVMVersionToolkit.java
Outdated
Show resolved
Hide resolved
...rg.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/version/JavaVMVersionToolkit.java
Outdated
Show resolved
Hide resolved
...rg.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/version/JavaVMVersionToolkit.java
Outdated
Show resolved
Hide resolved
@ojung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone, @Gunde) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
@thegreystone @ojung Since your change was applied there have been 2 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit f2e80e7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR contains a rule for notifying users of JVM < OpenJDK8u302 to upgrade to avoid performance issues caused by https://bugs.openjdk.java.net/browse/JDK-8266723.
JFR recorded on OpenJDK 8u302 EA:
JFR recorded on OpenJDK 8u292:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/256/head:pull/256
$ git checkout pull/256
Update a local copy of the PR:
$ git checkout pull/256
$ git pull https://git.openjdk.java.net/jmc pull/256/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 256
View PR using the GUI difftool:
$ git pr show -t 256
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/256.diff