7041: Add Percentage column based on Duration in stack trace view

[Suchitainf]

This PR address the enhancement requested by one of our customers where they were missing the percentage column by duration in stacktrace view which was available in JMC 5.5. Currently we have percentage column which is calculating the percentage based on event count and there is no way user can configure that.

Since this functionality might not be used by many customers I have added a toggle icon in Stacktrace View so that user can set the view according to his preference and by default the new column will be hidden.

Default view showing toggle icon:

Percentage By Duration Column :

Please review the change and let me know your valuable feedback on this.

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JMC-7041: Add Percentage column based on Duration in stack trace view

Reviewers

• @bric3 (no known github.com user name / role) ⚠️ Review applies to 99765b9
• Alex Macdonald (@aptmac - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/257/head:pull/257
$ git checkout pull/257

Update a local copy of the PR:
$ git checkout pull/257
$ git pull https://git.openjdk.java.net/jmc pull/257/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 257

View PR using the GUI difftool:
$ git pr show -t 257

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/257.diff

[bridgekeeper]

👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (c1e3ca68)
• 00: Full (99765b95)

[aptmac]

The functionality here looks good to me.

My only nit is that the column doesn't appear to be created with set weights (maybe it's a linux thing?) and the width of the new column is very large.

For example, when trying it for the first time I was confused why the column wasn't appearing, but it is just created with a 0 size and needs to be drag expanded. Additionally, to be able to actually read the column contents the width has to be made very large to the point where it overlaps the other column, but again that's probably just a nit on the size of my monitor.

[openjdk]

@Suchitainf This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7041: Add Percentage column based on Duration in stack trace view

Reviewed-by: aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 7220aee: 7261: Enhance agent pom.xml for future library deployment

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[Suchitainf]

/integrate

[openjdk]

@Suchitainf Since your change was applied there has been 1 commit pushed to the master branch:

• 7220aee: 7261: Enhance agent pom.xml for future library deployment

Your commit was automatically rebased without conflicts.

Pushed as commit fbf2d9b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[Suchitainf]

The functionality here looks good to me.

My only nit is that the column doesn't appear to be created with set weights (maybe it's a linux thing?) and the width of the new column is very large.

For example, when trying it for the first time I was confused why the column wasn't appearing, but it is just created with a 0 size and needs to be drag expanded. Additionally, to be able to actually read the column contents the width has to be made very large to the point where it overlaps the other column, but again that's probably just a nit on the size of my monitor.

Thanks for the approval. It looks perfectly fine in Windows. I will create a separate bug and look into it for Linux.