Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6923: Retain treeview stack trace while switching between JFRs #259

Closed
wants to merge 2 commits into from

Conversation

guruhb
Copy link
Contributor

@guruhb guruhb commented Jun 3, 2021

Persist Treeviewer expanded items during main view (JfrEditor) switch. This behavior will help comparing two jfr recording.

Solution :

  1. StackTraceView is a Viewpart which lists the stacktraces of JfrEditor (EditorPart). Switching between JfrEditor or selecting other context (Event Browser, Filtered events, etc..) makes an update in stacktraceview by providing "Items" to list. This Lists are then presented to StackTraceModel with reducedTree (i.e only the Top frame is expanded) and rest of them are listed with its root.
    With this fix, Persisting the ExpandedElements based on Items and then setting back during Editor Switch.
  2. StackTraceFrame requires hashCode and equals in order to Distinguish between old and new frames. Or persisting the StackTraceModel will be bit more expensive then set and restoring the Expanded elements.

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6923: Retain treeview stack trace while switching between JFRs

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/259/head:pull/259
$ git checkout pull/259

Update a local copy of the PR:
$ git checkout pull/259
$ git pull https://git.openjdk.java.net/jmc pull/259/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 259

View PR using the GUI difftool:
$ git pr show -t 259

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/259.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 3, 2021

👋 Welcome back ghb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 3, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 3, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 9, 2021

@guruhb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6923: Retain treeview stack trace while switching between JFRs

Reviewed-by: aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 9, 2021
@guruhb
Copy link
Contributor Author

guruhb commented Jun 10, 2021

/integrate

@openjdk openjdk bot closed this Jun 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 10, 2021
@openjdk
Copy link

openjdk bot commented Jun 10, 2021

@guruhb Pushed as commit df466e7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants