6967: Add Percentage Column w.r.t 'Profiling Samples' in Thread table

[guruhb]

Adding "Percentage" column in Thread table (JavaApplication View). which is helpful in knowing the ratio w.r.t "Profiling Samples"
JMC 5.x had the Percentage Column in "Hot threads" tab.

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JMC-6967: Add Percentage Column w.r.t 'Profiling Samples' in Thread table

Reviewers

• Alex Macdonald (@aptmac - Committer)
• @bric3 (no known github.com user name / role) ⚠️ Review applies to 183e87a

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/260/head:pull/260
$ git checkout pull/260

Update a local copy of the PR:
$ git checkout pull/260
$ git pull https://git.openjdk.java.net/jmc pull/260/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 260

View PR using the GUI difftool:
$ git pr show -t 260

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/260.diff

[bridgekeeper]

👋 Welcome back ghb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 02: Full - Incremental (93135ff8)
• 01: Full - Incremental (183e87a2)
• 00: Full (2366040a)

[aptmac]

The column looks good to me, I did have a question about whether or not the strings should be externalized or not.

[aptmac]

This looks to be the only instance in the class that uses non-externalized strings, should these be put into Messages.java?

[guruhb]

This should have been externalised, Its fixed now, Please re-check and update your comments.

[bric3]

Same remark as @aptmac .
Looks good otherwise.

[openjdk]

@guruhb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6967: Add Percentage Column w.r.t 'Profiling Samples' in Thread table

Reviewed-by: aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• 6723a70: 7299: Accessibility Issue - Too low contrast on rule result values
• 8bc1247: 7272: Method profiling page should show the frame type
• a2995a1: 7264: Improve the performance of the JFR parser
• 8e2988e: 7268: Show icons for modifiers in the method profiling page
• d622dd3: 7267: Change artifact id from "org.openjdk.jmc.agent" to "agent"
• ad54a32: 7266: Context Switch event handling breaks if JMC has old and new types parsed simultaneously
• a5f81b7: 7266: Context Switch event handling breaks if JMC has old and new types parsed simultaneously
• df466e7: 6923: Retain treeview stack trace while switching between JFRs

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[guruhb]

/integrate

[openjdk]

Going to push as commit 7f38790.
Since your change was applied there have been 8 commits pushed to the master branch:

• 6723a70: 7299: Accessibility Issue - Too low contrast on rule result values
• 8bc1247: 7272: Method profiling page should show the frame type
• a2995a1: 7264: Improve the performance of the JFR parser
• 8e2988e: 7268: Show icons for modifiers in the method profiling page
• d622dd3: 7267: Change artifact id from "org.openjdk.jmc.agent" to "agent"
• ad54a32: 7266: Context Switch event handling breaks if JMC has old and new types parsed simultaneously
• a5f81b7: 7266: Context Switch event handling breaks if JMC has old and new types parsed simultaneously
• df466e7: 6923: Retain treeview stack trace while switching between JFRs

Your commit was automatically rebased without conflicts.

[openjdk]

@guruhb Pushed as commit 7f38790.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.