Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7267: Change artifact id from "org.openjdk.jmc.agent" to "agent" #261

Closed
wants to merge 1 commit into from

Conversation

reinhapa
Copy link
Member

@reinhapa reinhapa commented Jun 9, 2021

  • Changes the current artifact id from org.openjdk.jmc.agent to agent
  • Changes all agent artifact/version references within command line arguments accordingly

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7267: Change artifact id from "org.openjdk.jmc.agent" to "agent"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/261/head:pull/261
$ git checkout pull/261

Update a local copy of the PR:
$ git checkout pull/261
$ git pull https://git.openjdk.java.net/jmc pull/261/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 261

View PR using the GUI difftool:
$ git pr show -t 261

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/261.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2021

👋 Welcome back reinhapa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 9, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 9, 2021

Webrevs

Copy link
Contributor

@guruhb guruhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@openjdk
Copy link

openjdk bot commented Jun 10, 2021

@reinhapa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7267: Change artifact id from "org.openjdk.jmc.agent" to "agent"

Reviewed-by: ghb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • df466e7: 6923: Retain treeview stack trace while switching between JFRs

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@guruhb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jun 10, 2021
@reinhapa
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor label Jun 10, 2021
@openjdk
Copy link

openjdk bot commented Jun 10, 2021

@reinhapa
Your change (at version 2afa10d) is now ready to be sponsored by a Committer.

@guruhb
Copy link
Contributor

guruhb commented Jun 11, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 11, 2021

Going to push as commit d622dd3.
Since your change was applied there have been 3 commits pushed to the master branch:

  • ad54a32: 7266: Context Switch event handling breaks if JMC has old and new types parsed simultaneously
  • a5f81b7: 7266: Context Switch event handling breaks if JMC has old and new types parsed simultaneously
  • df466e7: 6923: Retain treeview stack trace while switching between JFRs

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

openjdk bot commented Jun 11, 2021

@guruhb @reinhapa Pushed as commit d622dd3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@reinhapa reinhapa deleted the jmc7267 branch October 2, 2021 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants