Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7272: Method profiling page should show the frame type #267

Closed
wants to merge 2 commits into from

Conversation

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Jun 16, 2021

Bot feels I am not talking enough (⚠️ The pull request body must not be empty). This line of text fixes Sad Bot.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7272: Method profiling page should show the frame type

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/267/head:pull/267
$ git checkout pull/267

Update a local copy of the PR:
$ git checkout pull/267
$ git pull https://git.openjdk.java.net/jmc pull/267/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 267

View PR using the GUI difftool:
$ git pr show -t 267

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/267.diff

7272: Method profiling page should show the frame type
@thegreystone thegreystone requested review from guruhb and Gunde Jun 16, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 16, 2021

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 16, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jun 17, 2021

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7272: Method profiling page should show the frame type

Reviewed-by: jpbempel, aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • a2995a1: 7264: Improve the performance of the JFR parser

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 17, 2021
@@ -136,7 +136,6 @@ public IQuantity getMember(U i) {
};
}
});

Copy link
Member

@aptmac aptmac Jun 17, 2021

Mainly out of curiosity, but I noticed that there are still extra lines scattered through this file, but I couldn't figure out a pattern. Is there a purpose behind the lines removed here and the ones that still remain?

Copy link
Member Author

@thegreystone thegreystone Jun 17, 2021

Well, some of them seemed to maybe indicate some sort of grouping so I left them. I should probably just remove them all. ;)

@aptmac
Copy link
Member

@aptmac aptmac commented Jun 17, 2021

Is the design of these icons standardized, and is there a place to find out in jmc what they mean? Should this information be added to the tooltip perhaps? Otherwise I added a couple of comments inline, other than those I think it looks good.

aptmac
aptmac approved these changes Jun 18, 2021
@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented Jun 18, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

Going to push as commit 8bc1247.
Since your change was applied there has been 1 commit pushed to the master branch:

  • a2995a1: 7264: Improve the performance of the JFR parser

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 18, 2021

@thegreystone Pushed as commit 8bc1247.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@thegreystone thegreystone deleted the 7272-frame-type branch Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants