Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7299: Accessibility Issue - Too low contrast on rule result values #268

Closed
wants to merge 1 commit into from

Conversation

Suchitainf
Copy link
Collaborator

@Suchitainf Suchitainf commented Jun 16, 2021

This PR addresses an accessibility issue where the contrast of the rules score on Automated Analysis screen is too low.

Please review the change and let me know if any changes are required.

The UI looks like this now:

image


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7299: Accessibility Issue - Too low contrast on rule result values

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/268/head:pull/268
$ git checkout pull/268

Update a local copy of the PR:
$ git checkout pull/268
$ git pull https://git.openjdk.java.net/jmc pull/268/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 268

View PR using the GUI difftool:
$ git pr show -t 268

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/268.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2021

👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 16, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 16, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 18, 2021

@Suchitainf This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7299: Accessibility Issue - Too low contrast on rule result values

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 8bc1247: 7272: Method profiling page should show the frame type
  • a2995a1: 7264: Improve the performance of the JFR parser

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 18, 2021
@Suchitainf
Copy link
Collaborator Author

Suchitainf commented Jun 20, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jun 20, 2021

Going to push as commit 6723a70.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 8bc1247: 7272: Method profiling page should show the frame type
  • a2995a1: 7264: Improve the performance of the JFR parser

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 20, 2021
@openjdk
Copy link

openjdk bot commented Jun 20, 2021

@Suchitainf Pushed as commit 6723a70.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants