Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7042: Bring back summary screen for Statistics on Object Allocation outside TLAB. #269

Closed
wants to merge 3 commits into from

Conversation

Suchitainf
Copy link
Collaborator

@Suchitainf Suchitainf commented Jun 18, 2021

This PR addresses the enhancement of adding General screen (providing summary) and By Class (table and graph) for allocations inside and outside TLAB.

The changes include the enhancement "7043: Bring back summary screen for Statistics on Object Allocation inside TLAB" as well.

Note: This is bring back feature i.e. which was present in JMC 5.5 but was missing in recent releases.

Please review the change and provide your valuable comments.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7042: Bring back summary screen for Statistics on Object Allocation outside TLAB.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/269/head:pull/269
$ git checkout pull/269

Update a local copy of the PR:
$ git checkout pull/269
$ git pull https://git.openjdk.java.net/jmc pull/269/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 269

View PR using the GUI difftool:
$ git pr show -t 269

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/269.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 18, 2021

👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jun 18, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 18, 2021

Webrevs

Copy link
Member

@aptmac aptmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the page looks good, I've left a couple of review comments inline.

For anyone that doesn't feel like building this pr, here's a screenshot of what it looks like:
Tab group:
2021-06-21-121513_331x35_scrot

Class Page:
2021-06-21-121713_1494x736_scrot

Summary Page:
2021-06-21-121729_1490x739_scrot

@Suchitainf Suchitainf requested a review from aptmac June 23, 2021 21:49
@openjdk
Copy link

openjdk bot commented Jun 24, 2021

@Suchitainf This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7042: Bring back summary screen for Statistics on Object Allocation outside TLAB.

Reviewed-by: aptmac, hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 24, 2021
@aptmac
Copy link
Member

aptmac commented Jun 24, 2021

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jun 24, 2021

@aptmac Only the author of the pull request or Reviewers are allowed to change the number of required reviewers.

@Suchitainf
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 5, 2021

Going to push as commit 81344ce.
Since your change was applied there have been 11 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 5, 2021
@openjdk
Copy link

openjdk bot commented Jul 5, 2021

@Suchitainf Pushed as commit 81344ce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants