-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7042: Bring back summary screen for Statistics on Object Allocation outside TLAB. #269
Conversation
👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...lightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DataPageToolkit.java
Outdated
Show resolved
Hide resolved
...dk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/TlabPage.java
Outdated
Show resolved
Hide resolved
...dk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/TlabPage.java
Outdated
Show resolved
Hide resolved
...dk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/TlabPage.java
Show resolved
Hide resolved
...i/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages.properties
Outdated
Show resolved
Hide resolved
@Suchitainf This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/reviewers 2 |
/integrate |
Going to push as commit 81344ce.
Your commit was automatically rebased without conflicts. |
@Suchitainf Pushed as commit 81344ce. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR addresses the enhancement of adding General screen (providing summary) and By Class (table and graph) for allocations inside and outside TLAB.
The changes include the enhancement "7043: Bring back summary screen for Statistics on Object Allocation inside TLAB" as well.
Note: This is bring back feature i.e. which was present in JMC 5.5 but was missing in recent releases.
Please review the change and provide your valuable comments.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/269/head:pull/269
$ git checkout pull/269
Update a local copy of the PR:
$ git checkout pull/269
$ git pull https://git.openjdk.java.net/jmc pull/269/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 269
View PR using the GUI difftool:
$ git pr show -t 269
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/269.diff