4792: Stop using System.out/err.println and e.printStackTrace #272

jpbempel · 2021-07-05T09:56:33Z

replaced by java.util.logging logging

Progress

Commit message must refer to an issue
Change must be properly reviewed

Issue

JMC-4792: Stop using System.out/err.println and e.printStackTrace

Reviewers

Marcus Hirt (@thegreystone - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/272/head:pull/272
$ git checkout pull/272

Update a local copy of the PR:
$ git checkout pull/272
$ git pull https://git.openjdk.java.net/jmc pull/272/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 272

View PR using the GUI difftool:
$ git pr show -t 272

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/272.diff

replaced by java.util.logging logging

bridgekeeper · 2021-07-05T09:57:56Z

👋 Welcome back jpbempel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

mlbridge · 2021-07-05T10:02:02Z

Webrevs

thegreystone · 2021-07-05T10:37:16Z

agent/src/main/java/org/openjdk/jmc/agent/jfrlegacy/impl/JFRUtils.java

@@ -78,7 +78,7 @@ private static Method getRegisterMethod(Class<?> producerClass) {
 			// This should never happen
 			Agent.getLogger().severe("Failed to find the addEvent method of the producer.");


Let's just roll them up into one logger call with stacktrace.

thegreystone · 2021-07-05T10:40:23Z

...ava/org/openjdk/jmc/flightrecorder/controlpanel/ui/model/ConfigurationRepositoryFactory.java

@@ -110,10 +110,10 @@ public boolean accept(File dir, String name) {
 					repository.add(template);
 				} catch (IOException e) {
 					// FIXME: Better exception handling
-					e.printStackTrace();
+					ControlPanel.getDefault().getLogger().log(Level.SEVERE, "", e);


"Failed to load local template from file"?

thegreystone · 2021-07-05T10:41:22Z

...ava/org/openjdk/jmc/flightrecorder/controlpanel/ui/model/ConfigurationRepositoryFactory.java

 				} catch (ParseException e) {
 					// FIXME: Better exception handling
-					e.printStackTrace();
+					ControlPanel.getDefault().getLogger().log(Level.SEVERE, "", e);


"Failed to parse local template from file " + file...

thegreystone · 2021-07-05T10:42:12Z

...c/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingWizardModel.java

@@ -237,13 +237,13 @@ private EventConfigurationRepository createRepository(IFlightRecorderService flr
 					repo.add(new EventConfiguration(EventConfiguration.createModel(templateXML),
 							VolatileStorageDelegate.getOnServerDelegate()));
 				} catch (ParseException e) {
-					e.printStackTrace();
+					ControlPanel.getDefault().getLogger().log(Level.SEVERE, "", e);


Add helpful message?

thegreystone · 2021-07-05T10:42:19Z

...c/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingWizardModel.java

 				} catch (IOException e) {
-					e.printStackTrace();
+					ControlPanel.getDefault().getLogger().log(Level.SEVERE, "", e);


Add helpful message?

thegreystone · 2021-07-05T10:42:23Z

...c/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingWizardModel.java

 				}
 			}
 		} catch (FlightRecorderException e) {
-			e.printStackTrace();
+			ControlPanel.getDefault().getLogger().log(Level.SEVERE, "", e);


Add helpful message?

thegreystone · 2021-07-05T10:42:32Z

...openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/JfrEditor.java

@@ -380,7 +380,7 @@ void repositoryLoaded(EventArrays repo, IRange<IQuantity> fullRange) {
 			try {
 				getSite().getPage().showView(CONTENT_OUTLINE_VIEW_ID, null, IWorkbenchPage.VIEW_VISIBLE);
 			} catch (PartInitException e) {
-				e.printStackTrace();
+				FlightRecorderUI.getDefault().getLogger().log(Level.SEVERE, "", e);


Add helpful message?

thegreystone · 2021-07-05T10:42:43Z

...lightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DataPageToolkit.java

@@ -1100,8 +1103,7 @@ private void chooseImageFileDialog() {
 						imageLabel.getParent().layout();
 						setPageComplete(isPageComplete());
 					} catch (Exception e) {
-						// FIXME: Add proper logging
-						e.printStackTrace();
+						LOGGER.log(Level.SEVERE, "", e);


Add helpful message?

thegreystone · 2021-07-05T10:42:50Z

....ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/itemhandler/HistogramSequence.java

@@ -159,7 +162,7 @@ private void setGroupByField(IAttribute<?> attribute, Boolean ignore) {
 				try {
 					buildHistogram();
 				} catch (Exception e) {
-					e.printStackTrace();
+					LOGGER.log(Level.SEVERE, "", e);


Add helpful message?

thegreystone · 2021-07-05T10:42:56Z

....ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/itemhandler/HistogramSequence.java

@@ -176,7 +179,7 @@ private void combinedGrouping(IAttribute<?> attribute, Boolean ignore) {
 			try {
 				buildHistogram();
 			} catch (Exception e) {
-				e.printStackTrace();
+				LOGGER.log(Level.SEVERE, "", e);


Add helpful message?

thegreystone · 2021-07-05T10:43:02Z

...flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/preferences/RulesPage.java

@@ -208,7 +208,7 @@ protected void performApply() {
 			checkedRuleIDs.forEach(id -> ignoredState.createChild(IGNORED_RULES).putString(RULE_ID, id));
 			getPreferenceStore().setValue(IGNORED_RULES, ignoredState.toString());
 		} catch (IOException e) {
-			e.printStackTrace();
+			FlightRecorderUI.getDefault().getLogger().log(Level.SEVERE, "", e);


Add helpful message?

thegreystone · 2021-07-05T10:45:20Z

...penjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/util/ChunkReader.java

@@ -116,7 +119,7 @@ public boolean hasNext() {
 					file.close();
 				} catch (IOException e) {
 					// Shouldn't happen.
-					e.printStackTrace();
+					LOGGER.log(Level.SEVERE, "", e);


Add helpful message?

openjdk · 2021-07-22T12:12:42Z

@jpbempel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

4792: Stop using System.out/err.println and e.printStackTrace

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

b0b037a: 7344: Unhandled exception in rule evaluation
5a3e303: 7324: Update eclipse version and Min JDK required in Update Site landing pages
362414b: 7329: Exception while opening Method Profile page.
11e547a: 7328: Incorrect sort order in method profiling page
f5a9cf3: 7327: Constant Pool optimizations
2e8a251: 7167: Agent Plugin
1d7397e: 6204: Flight recorder launcher tab bugs out
81344ce: 7042: Bring back summary screen for Statistics on Object Allocation outside TLAB.
e838a74: 7304: JMC 8.0.1 fix formatting failure
66685ca: 7188: JMC fails to dump file and gets stuck when flightrecording is attempted on jmxremote connection
... and 5 more: https://git.openjdk.java.net/jmc/compare/7f387907c6a4b903968d3c3656c713a262a4da4d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

jpbempel · 2021-07-22T12:29:49Z

/integrate

openjdk · 2021-07-22T12:31:12Z

Going to push as commit c6e0606.
Since your change was applied there have been 15 commits pushed to the master branch:

b0b037a: 7344: Unhandled exception in rule evaluation
5a3e303: 7324: Update eclipse version and Min JDK required in Update Site landing pages
362414b: 7329: Exception while opening Method Profile page.
11e547a: 7328: Incorrect sort order in method profiling page
f5a9cf3: 7327: Constant Pool optimizations
2e8a251: 7167: Agent Plugin
1d7397e: 6204: Flight recorder launcher tab bugs out
81344ce: 7042: Bring back summary screen for Statistics on Object Allocation outside TLAB.
e838a74: 7304: JMC 8.0.1 fix formatting failure
66685ca: 7188: JMC fails to dump file and gets stuck when flightrecording is attempted on jmxremote connection
... and 5 more: https://git.openjdk.java.net/jmc/compare/7f387907c6a4b903968d3c3656c713a262a4da4d...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-07-22T12:31:27Z

@jpbempel Pushed as commit c6e0606.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

4792: Stop using System.out/err.println and e.printStackTrace

9cfba8c

replaced by java.util.logging logging

openjdk bot added the rfr label Jul 5, 2021

spotless

5589265

thegreystone reviewed Jul 5, 2021

View reviewed changes

jpbempel added 2 commits July 5, 2021 18:50

add helpful messages

d948fa3

spotless

980aa8f

thegreystone approved these changes Jul 22, 2021

View reviewed changes

openjdk bot added the ready label Jul 22, 2021

openjdk bot closed this Jul 22, 2021

openjdk bot added integrated and removed ready rfr labels Jul 22, 2021

jpbempel deleted the 4792 branch September 10, 2021 20:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

4792: Stop using System.out/err.println and e.printStackTrace #272

4792: Stop using System.out/err.println and e.printStackTrace #272

jpbempel commented Jul 5, 2021 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jul 5, 2021

mlbridge bot commented Jul 5, 2021 •

edited

Loading

thegreystone Jul 5, 2021

thegreystone Jul 5, 2021

thegreystone Jul 5, 2021

thegreystone Jul 5, 2021

thegreystone Jul 5, 2021

thegreystone Jul 5, 2021

thegreystone Jul 5, 2021

thegreystone Jul 5, 2021

thegreystone Jul 5, 2021

thegreystone Jul 5, 2021

thegreystone Jul 5, 2021

thegreystone Jul 5, 2021

openjdk bot commented Jul 22, 2021

jpbempel commented Jul 22, 2021

openjdk bot commented Jul 22, 2021

openjdk bot commented Jul 22, 2021

		@@ -78,7 +78,7 @@ private static Method getRegisterMethod(Class<?> producerClass) {
		// This should never happen
		Agent.getLogger().severe("Failed to find the addEvent method of the producer.");

4792: Stop using System.out/err.println and e.printStackTrace #272

4792: Stop using System.out/err.println and e.printStackTrace #272

Conversation

jpbempel commented Jul 5, 2021 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jul 5, 2021

mlbridge bot commented Jul 5, 2021 • edited Loading

Webrevs

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openjdk bot commented Jul 22, 2021

jpbempel commented Jul 22, 2021

openjdk bot commented Jul 22, 2021

openjdk bot commented Jul 22, 2021

jpbempel commented Jul 5, 2021 •

edited by openjdk bot

Loading

mlbridge bot commented Jul 5, 2021 •

edited

Loading