-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7338: Add parser support for frame types generated by async-profiler #274
Conversation
👋 Welcome back jbachorik! A progress list of the required criteria for merging this PR into |
Webrevs
|
core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCFrame.java
Outdated
Show resolved
Hide resolved
...flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/util/ParserToolkit.java
Outdated
Show resolved
Hide resolved
Also, just a reminder that no reviewer should approve this PR until the master branch is updated to 8.2.0. |
cd04fb8
to
6b8a5f3
Compare
@jbachorik This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 25 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@jbachorik |
/sponsor |
Going to push as commit 341f3d5.
Your commit was automatically rebased without conflicts. |
@thegreystone @jbachorik Pushed as commit 341f3d5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Async Profiler (https://github.com/jvm-profiling-tools/async-profiler) is able to generate JFR recordings with CPU and allocation sample events spanning full-stack (from Java to OS/kernel).
It is adding three new frame types for this reason:
Currently, the JMC parser will process all those frame types as 'UNKNOWN'. Although it is not breaking the rendering it would be nice to be able to get more info about the actual frame type.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/274/head:pull/274
$ git checkout pull/274
Update a local copy of the PR:
$ git checkout pull/274
$ git pull https://git.openjdk.java.net/jmc pull/274/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 274
View PR using the GUI difftool:
$ git pr show -t 274
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/274.diff