Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7338: Add parser support for frame types generated by async-profiler #274

Closed
wants to merge 1 commit into from

Conversation

jbachorik
Copy link
Collaborator

@jbachorik jbachorik commented Jul 9, 2021

Async Profiler (https://github.com/jvm-profiling-tools/async-profiler) is able to generate JFR recordings with CPU and allocation sample events spanning full-stack (from Java to OS/kernel).
It is adding three new frame types for this reason:

  • Native (C)
  • C++
  • Kernel

Currently, the JMC parser will process all those frame types as 'UNKNOWN'. Although it is not breaking the rendering it would be nice to be able to get more info about the actual frame type.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7338: Add parser support for frame types generated by async-profiler

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/274/head:pull/274
$ git checkout pull/274

Update a local copy of the PR:
$ git checkout pull/274
$ git pull https://git.openjdk.java.net/jmc pull/274/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 274

View PR using the GUI difftool:
$ git pr show -t 274

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/274.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 9, 2021

👋 Welcome back jbachorik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 9, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 9, 2021

Webrevs

@thegreystone
Copy link
Member

Also, just a reminder that no reviewer should approve this PR until the master branch is updated to 8.2.0.

@thegreystone thegreystone changed the title JMC-7338: Add parser support for frame types generated by async-profiler 7338: Add parser support for frame types generated by async-profiler Jul 9, 2021
@jbachorik jbachorik force-pushed the jb/async_profiler branch from cd04fb8 to 6b8a5f3 Compare July 9, 2021 16:18
@openjdk
Copy link

openjdk bot commented Aug 18, 2021

@jbachorik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7338: Add parser support for frame types generated by async-profiler

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Aug 18, 2021
@jbachorik
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot added the sponsor label Sep 9, 2021
@openjdk
Copy link

openjdk bot commented Sep 9, 2021

@jbachorik
Your change (at version 6b8a5f3) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 9, 2021

Going to push as commit 341f3d5.
Since your change was applied there have been 25 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 9, 2021
@openjdk
Copy link

openjdk bot commented Sep 9, 2021

@thegreystone @jbachorik Pushed as commit 341f3d5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants