-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6922: Reintroduce GC summary screen #275
Conversation
👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/reviewers 2
@Suchitainf This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/reviewers 2 |
@guruhb |
I'm checking the PR and it seems all is find and work, I've not found any issue during my tests |
/integrate |
Going to push as commit c54c00b.
Your commit was automatically rebased without conflicts. |
@Suchitainf Pushed as commit c54c00b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR addresses the enhancement of adding a new screen "GC Summary" which will cover missing information from "GC Times" screen present in JMC 5.5.
Here is the preview of the new screen added for the reference:
Here is the preview of the reference screen from JMC 5.5
I have opened same JFR in both the versions, so that values can be compared while review.
Please review the changes and let me know your valuable comments.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/275/head:pull/275
$ git checkout pull/275
Update a local copy of the PR:
$ git checkout pull/275
$ git pull https://git.openjdk.java.net/jmc pull/275/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 275
View PR using the GUI difftool:
$ git pr show -t 275
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/275.diff