Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6922: Reintroduce GC summary screen #275

Closed
wants to merge 1 commit into from

Conversation

Suchitainf
Copy link
Collaborator

@Suchitainf Suchitainf commented Jul 9, 2021

This PR addresses the enhancement of adding a new screen "GC Summary" which will cover missing information from "GC Times" screen present in JMC 5.5.

Here is the preview of the new screen added for the reference:

image

Here is the preview of the reference screen from JMC 5.5

image

I have opened same JFR in both the versions, so that values can be compared while review.

Please review the changes and let me know your valuable comments.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-6922: Reintroduce GC summary screen

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/275/head:pull/275
$ git checkout pull/275

Update a local copy of the PR:
$ git checkout pull/275
$ git pull https://git.openjdk.java.net/jmc pull/275/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 275

View PR using the GUI difftool:
$ git pr show -t 275

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/275.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 9, 2021

👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 9, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 9, 2021

Webrevs

Copy link
Contributor

@guruhb guruhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jul 19, 2021

@Suchitainf This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6922: Reintroduce GC summary screen

Reviewed-by: ghb, aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 5a3e303: 7324: Update eclipse version and Min JDK required in Update Site landing pages
  • 362414b: 7329: Exception while opening Method Profile page.
  • 11e547a: 7328: Incorrect sort order in method profiling page
  • f5a9cf3: 7327: Constant Pool optimizations
  • 2e8a251: 7167: Agent Plugin
  • 1d7397e: 6204: Flight recorder launcher tab bugs out

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 19, 2021
@guruhb
Copy link
Contributor

guruhb commented Jul 19, 2021

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jul 19, 2021

@guruhb
The number of required reviews for this PR is now set to 2 (with at least 1 of role committers).

@openjdk openjdk bot removed the ready label Jul 19, 2021
@mirage22
Copy link
Collaborator

mirage22 commented Jul 21, 2021

I'm checking the PR and it seems all is find and work, I've not found any issue during my tests

@openjdk openjdk bot added the ready label Jul 21, 2021
@Suchitainf
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 22, 2021

Going to push as commit c54c00b.
Since your change was applied there have been 8 commits pushed to the master branch:

  • c6e0606: 4792: Stop using System.out/err.println and e.printStackTrace
  • b0b037a: 7344: Unhandled exception in rule evaluation
  • 5a3e303: 7324: Update eclipse version and Min JDK required in Update Site landing pages
  • 362414b: 7329: Exception while opening Method Profile page.
  • 11e547a: 7328: Incorrect sort order in method profiling page
  • f5a9cf3: 7327: Constant Pool optimizations
  • 2e8a251: 7167: Agent Plugin
  • 1d7397e: 6204: Flight recorder launcher tab bugs out

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 22, 2021
@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@Suchitainf Pushed as commit c54c00b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants