Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7344: Unhandled exception in rule evaluation #280

Closed
wants to merge 1 commit into from

Conversation

guruhb
Copy link
Contributor

@guruhb guruhb commented Jul 21, 2021

With JFR generated from JDK17-ea "usedSize" event was missing (i.e not generated) due to this the used aggregator was null.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7344: Unhandled exception in rule evaluation

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/280/head:pull/280
$ git checkout pull/280

Update a local copy of the PR:
$ git checkout pull/280
$ git pull https://git.openjdk.java.net/jmc pull/280/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 280

View PR using the GUI difftool:
$ git pr show -t 280

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/280.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2021

👋 Welcome back ghb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 21, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 21, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@guruhb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7344: Unhandled exception in rule evaluation

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 22, 2021
@guruhb
Copy link
Contributor Author

guruhb commented Jul 22, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jul 22, 2021

Going to push as commit b0b037a.

@openjdk openjdk bot closed this Jul 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 22, 2021
@openjdk
Copy link

openjdk bot commented Jul 22, 2021

@guruhb Pushed as commit b0b037a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants