Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7362: Reference wrong in agent plug-in.xml #283

Closed

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Jul 26, 2021

Also cleaning up and making it possible to use the project from within Eclipse.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7362: Reference wrong in agent plug-in.xml

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/283/head:pull/283
$ git checkout pull/283

Update a local copy of the PR:
$ git checkout pull/283
$ git pull https://git.openjdk.java.net/jmc pull/283/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 283

View PR using the GUI difftool:
$ git pr show -t 283

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/283.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 26, 2021

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@thegreystone thegreystone requested a review from guruhb July 26, 2021 10:00
@openjdk openjdk bot added the rfr label Jul 26, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 26, 2021

Webrevs

@thegreystone thegreystone requested a review from aptmac July 26, 2021 10:12
Copy link
Contributor

@guruhb guruhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me .

@openjdk
Copy link

openjdk bot commented Jul 26, 2021

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7362: Reference wrong in agent plug-in.xml

Reviewed-by: ghb, aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 26, 2021
@thegreystone
Copy link
Member Author

/reviewers 2

@thegreystone
Copy link
Member Author

Adding a second reviewer since we're in ramp down 2.

@openjdk
Copy link

openjdk bot commented Jul 26, 2021

@thegreystone
The number of required reviews for this PR is now set to 2 (with at least 1 of role committers).

@openjdk openjdk bot removed the ready label Jul 26, 2021
@openjdk openjdk bot added the ready label Jul 26, 2021
@thegreystone
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 26, 2021

Going to push as commit 4b492a4.

@openjdk openjdk bot closed this Jul 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 26, 2021
@openjdk
Copy link

openjdk bot commented Jul 26, 2021

@thegreystone Pushed as commit 4b492a4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@thegreystone thegreystone deleted the 7362-wrong-editor-reference branch July 26, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants