-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7362: Reference wrong in agent plug-in.xml #283
7362: Reference wrong in agent plug-in.xml #283
Conversation
👋 Welcome back hirt! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me .
@thegreystone This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/reviewers 2 |
Adding a second reviewer since we're in ramp down 2. |
@thegreystone |
/integrate |
Going to push as commit 4b492a4. |
@thegreystone Pushed as commit 4b492a4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Also cleaning up and making it possible to use the project from within Eclipse.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/283/head:pull/283
$ git checkout pull/283
Update a local copy of the PR:
$ git checkout pull/283
$ git pull https://git.openjdk.java.net/jmc pull/283/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 283
View PR using the GUI difftool:
$ git pr show -t 283
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/283.diff