Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7265: Update Release Notes for 8.1.0 #285

Closed

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Jul 26, 2021

Updated for 8.1.0.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7265: Update Release Notes for 8.1.0

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/285/head:pull/285
$ git checkout pull/285

Update a local copy of the PR:
$ git checkout pull/285
$ git pull https://git.openjdk.java.net/jmc pull/285/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 285

View PR using the GUI difftool:
$ git pr show -t 285

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/285.diff

@thegreystone thegreystone requested review from aptmac, Gunde and guruhb July 26, 2021 18:08
@thegreystone
Copy link
Member Author

Let me know if I forgot something that should be mentioned.

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 26, 2021

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@thegreystone thegreystone marked this pull request as ready for review July 28, 2021 17:24
@openjdk openjdk bot added the rfr label Jul 28, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 28, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 29, 2021

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7265: Update Release Notes for 8.1.0

Reviewed-by: jpbempel, ghb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 29, 2021
@thegreystone
Copy link
Member Author

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jul 29, 2021

@thegreystone
The number of required reviews for this PR is now set to 2 (with at least 1 of role committers).

@openjdk openjdk bot removed the ready label Jul 29, 2021
Copy link
Contributor

@guruhb guruhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@openjdk openjdk bot added the ready label Jul 29, 2021
</description>
</issue>
<issue>
<area>JFR</area>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be an issue now after: eafd075

@thegreystone
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 30, 2021

Going to push as commit f1cae17.
Since your change was applied there have been 30 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 30, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 30, 2021
@openjdk
Copy link

openjdk bot commented Jul 30, 2021

@thegreystone Pushed as commit f1cae17.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@thegreystone thegreystone deleted the 7265-8-1-release-notes branch July 31, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants