Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7366: Agent Plugin Object Contributions to Methods #288

Closed

Conversation

Josh-Matsuoka
Copy link
Collaborator

@Josh-Matsuoka Josh-Matsuoka commented Jul 27, 2021

This PR addresses JMC-7366, adding Object Contributions for method types in JMC. This allows users to right click on a method in the UI and create an agent plugin probe template for that method, simplifying the user experience a bit.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7366: Agent Plugin Object Contributions to Methods

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/288/head:pull/288
$ git checkout pull/288

Update a local copy of the PR:
$ git checkout pull/288
$ git pull https://git.openjdk.java.net/jmc pull/288/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 288

View PR using the GUI difftool:
$ git pr show -t 288

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/288.diff

@Josh-Matsuoka Josh-Matsuoka changed the title Object contributions 7366: Object contributions Jul 27, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 27, 2021

👋 Welcome back jmatsuoka! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 27, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 27, 2021

Webrevs

@thegreystone thegreystone requested a review from aptmac July 29, 2021 20:08
@thegreystone thegreystone changed the title 7366: Object contributions 7366: Agent Plugin Object Contributions to Methods Jul 29, 2021
@thegreystone
Copy link
Member

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jul 29, 2021

@Josh-Matsuoka This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7366: Agent Plugin Object Contributions to Methods

Reviewed-by: hirt, aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 29, 2021
@openjdk
Copy link

openjdk bot commented Jul 29, 2021

@thegreystone
The number of required reviews for this PR is now set to 2 (with at least 1 of role committers).

@openjdk openjdk bot removed the ready label Jul 29, 2021
@openjdk openjdk bot added the ready label Jul 29, 2021
@thegreystone
Copy link
Member

@Josh-Matsuoka - please /integrate.

@Josh-Matsuoka
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 30, 2021

Going to push as commit ef023e3.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 70901a3: 7357: Double-Checked Locking in Agent Plugin code

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 30, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 30, 2021
@openjdk
Copy link

openjdk bot commented Jul 30, 2021

@Josh-Matsuoka Pushed as commit ef023e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants