-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7366: Agent Plugin Object Contributions to Methods #288
Conversation
👋 Welcome back jmatsuoka! A progress list of the required criteria for merging this PR into |
....agent/src/main/java/org/openjdk/jmc/console/agent/contribution/CreateMethodProbeDialog.java
Outdated
Show resolved
Hide resolved
...le.agent/src/main/java/org/openjdk/jmc/console/agent/contribution/CreateMethodProbePage.java
Outdated
Show resolved
Hide resolved
/reviewers 2 |
@Josh-Matsuoka This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@thegreystone |
@Josh-Matsuoka - please /integrate. |
/integrate |
@Josh-Matsuoka Pushed as commit ef023e3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR addresses JMC-7366, adding Object Contributions for method types in JMC. This allows users to right click on a method in the UI and create an agent plugin probe template for that method, simplifying the user experience a bit.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/288/head:pull/288
$ git checkout pull/288
Update a local copy of the PR:
$ git checkout pull/288
$ git pull https://git.openjdk.java.net/jmc pull/288/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 288
View PR using the GUI difftool:
$ git pr show -t 288
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/288.diff