-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7348: JMC preference options are duplicated #289
Conversation
👋 Welcome back ghb! A progress list of the required criteria for merging this PR into |
Webrevs
|
@@ -1,4 +1,37 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> | |||
<!-- | |||
Copyright (c) 2021 Oracle and/or its affiliates. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comma after year.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed now.. Please re-check with latest commit
/integrate |
@guruhb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
"General" , "Appearance" and "Keys" had duplicate entry . This was due to some in consistence "org.eclipse.ui.*" Components were used (one with older + latest version which is causing duplicate entry).
Solution : adding "resolution:=optional" resolves the duplicate entry.
Restricted the Eclipse UI components to v3.2.0 and less than equal to 4.0.0.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/289/head:pull/289
$ git checkout pull/289
Update a local copy of the PR:
$ git checkout pull/289
$ git pull https://git.openjdk.java.net/jmc pull/289/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 289
View PR using the GUI difftool:
$ git pr show -t 289
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/289.diff