Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7377: Update master to 8.2 #298

Closed

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Aug 4, 2021

Also updating splash.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/298/head:pull/298
$ git checkout pull/298

Update a local copy of the PR:
$ git checkout pull/298
$ git pull https://git.openjdk.java.net/jmc pull/298/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 298

View PR using the GUI difftool:
$ git pr show -t 298

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/298.diff

@thegreystone thegreystone requested a review from guruhb August 4, 2021 23:43
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2021

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 4, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 4, 2021

Webrevs

@@ -44,7 +44,6 @@
</parent>

<artifactId>org.openjdk.jmc.console.agent</artifactId>
<version>8.1.0-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok to remove this version element?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. It shouldn't be there in the first place, rather inherited.

@guruhb
Copy link
Contributor

guruhb commented Aug 5, 2021

please update in

  1. README.md (ln 369)
  2. UpdateSiteTest.java ln 59)

@openjdk
Copy link

openjdk bot commented Aug 5, 2021

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7377: Update master to 8.2

Reviewed-by: jpbempel, ghb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 5, 2021
@thegreystone
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 5, 2021

Going to push as commit 511071d.

@openjdk openjdk bot closed this Aug 5, 2021
@openjdk openjdk bot added integrated and removed ready labels Aug 5, 2021
@thegreystone thegreystone deleted the 7377-update-master-to-8.2 branch August 5, 2021 22:21
@openjdk openjdk bot removed the rfr label Aug 5, 2021
@openjdk
Copy link

openjdk bot commented Aug 5, 2021

@thegreystone Pushed as commit 511071d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants