Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6632: Tighten up english rule messages #3

Closed
wants to merge 5 commits into from

Conversation

@dbenamydd
Copy link
Contributor

dbenamydd commented Nov 15, 2019

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JMC-6632: Clean up the rule heuristics text

Approvers

  • Marcus Hirt (hirt - Reviewer) Note! Review applies to 3681500
  • Henrik Dafgård (hdafgard - Reviewer)
@bridgekeeper bridgekeeper bot added the oca label Nov 15, 2019
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2019

Hi dbenamydd, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user dbenamydd" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

Copy link
Collaborator

thegreystone left a comment

Aside from the project preference to use ISO 31-0 style space between the number and the percent sign, it all looks good to me.

@thegreystone
Copy link
Collaborator

thegreystone commented Nov 15, 2019

Issue number to refer to is 6632.

@dbenamydd dbenamydd changed the title Tighten up english rule messages 6632: Tighten up english rule messages Nov 15, 2019
@dbenamydd
Copy link
Contributor Author

dbenamydd commented Nov 15, 2019

/covered

@bridgekeeper bridgekeeper bot added the oca-verify label Nov 15, 2019
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2019

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

This is the project's preferred style.
@openjdk openjdk bot added the rfr label Nov 21, 2019
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2019

@openjdk openjdk bot removed the rfr label Nov 22, 2019
@openjdk
Copy link

openjdk bot commented Nov 22, 2019

@dbenamydd This change can now be integrated. The commit message will be:

6632: Tighten up english rule messages

Reviewed-by: hirt, hdafgard
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • 046390e: 6604: Adding EA splash for JMC 8
  • 481f15b: 6631: Updating version to 8.0.0

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

As you are not a known OpenJDK Author, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone, @Gunde) but any other Committer may sponsor as well.

  • To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).
@openjdk openjdk bot added the ready label Nov 22, 2019
@dbenamydd
Copy link
Contributor Author

dbenamydd commented Nov 22, 2019

/integrate

@openjdk
Copy link

openjdk bot commented Nov 22, 2019

@dbenamydd
Your change (at version 3681500) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added the sponsor label Nov 22, 2019
@thegreystone
Copy link
Collaborator

thegreystone commented Nov 22, 2019

Need to update the tests too! :)

@openjdk openjdk bot removed the sponsor label Nov 22, 2019
@Gunde
Gunde approved these changes Nov 22, 2019
@Gunde
Gunde approved these changes Nov 22, 2019
@dbenamydd
Copy link
Contributor Author

dbenamydd commented Nov 22, 2019

/integrate

@openjdk openjdk bot added the sponsor label Nov 22, 2019
@openjdk
Copy link

openjdk bot commented Nov 22, 2019

@dbenamydd
Your change (at version facfd30) is now ready to be sponsored by a Committer.

@Gunde
Copy link

Gunde commented Nov 22, 2019

/sponsor

@openjdk openjdk bot closed this Nov 22, 2019
@openjdk openjdk bot added integrated and removed sponsor ready labels Nov 22, 2019
@openjdk
Copy link

openjdk bot commented Nov 22, 2019

@Gunde @dbenamydd The following commits have been pushed to master since your change was applied:

  • 046390e: 6604: Adding EA splash for JMC 8
  • 481f15b: 6631: Updating version to 8.0.0

Your commit was automatically rebased without conflicts.

Pushed as commit cf825ca.

@mlbridge
Copy link

mlbridge bot commented Nov 22, 2019

Mailing list message from Henrik Dafgård on jmc-dev:

Changeset: cf825ca
Author: Dan Benamy
Committer: Henrik Dafg?rd
Date: 2019-11-22 21:18:27 +0000
URL: https://git.openjdk.java.net/jmc/commit/cf825cae

6632: Tighten up english rule messages

Reviewed-by: hirt, hdafgard

! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages.properties
! core/tests/org.openjdk.jmc.flightrecorder.rules.jdk.test/src/test/resources/baseline/JfrRuleBaseline.xml

thegreystone added a commit to thegreystone/jmc that referenced this pull request Nov 23, 2019
…ons and rethrow (openjdk#3)

* JMC-5967: Generated code should optionally capture any thrown exceptions and rethrow

Summary: implemented an optional configuration for the generated code to capture any thrown exceptions, emit the event, and then re-throw.
Contributed-by: Kangcheng Xu <kxu@redhat.com>
aptmac added a commit to aptmac/jmc that referenced this pull request Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.