Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6671: Eagerly convert end time to the same unit as start time #30

Closed
wants to merge 1 commit into from

Conversation

@Gunde
Copy link
Collaborator

@Gunde Gunde commented Jan 13, 2020

Set event end time to use the same unit as start time when accessing the values, rather than when comparing between them.

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JMC-6671: DisjointBuilder is slow for large quantities of duration events

Approvers

  • Marcus Hirt (hirt - Reviewer)
Set event end time to use the same unit as start time when accessing the values, rather than when comparing between them.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 13, 2020

👋 Welcome back hdafgard! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Jan 13, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 13, 2020

Webrevs

@openjdk openjdk bot removed the rfr label Jan 13, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 13, 2020

@Gunde This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6671: Eagerly convert end time to the same unit as start time

Reviewed-by: hirt
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.
    ➡️ To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Jan 13, 2020
@Gunde
Copy link
Collaborator Author

@Gunde Gunde commented Jan 13, 2020

/integrate

@openjdk openjdk bot closed this Jan 13, 2020
@openjdk openjdk bot added integrated and removed ready labels Jan 13, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 13, 2020

@Gunde
Pushed as commit bfb23cd.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 13, 2020

Mailing list message from Henrik Dafgård on jmc-dev:

Changeset: bfb23cd
Author: Henrik Dafg?rd <hdafgard at openjdk.org>
Date: 2020-01-13 21:33:40 +0000
URL: https://git.openjdk.java.net/jmc/commit/bfb23cde

6671: Eagerly convert end time to the same unit as start time

Reviewed-by: hirt

! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/util/DisjointBuilder.java

@Gunde Gunde deleted the Gunde:6671-speedup-disjoint-builder branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants