Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7308: Move non-Eclipse dependant classes from org.openjdk.jmc.ui.common to org.openjdk.jmc.common #300

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

@aptmac
Copy link
Member

@aptmac aptmac commented Aug 9, 2021

This PR addresses JMC-7308 [0], in which it would be helpful to have some of the classes currently in jmc.ui.common shipped in core.

There are a number of classes currently in jmc.ui.common that would be a great asset to the core distribution (and the third-party applications that consume jmc-core), and these classes could live in jmc.common.

It isn't as straightforward as moving all of the packages to core, as there are still classes in these jmc.ui.common packages that have dependencies on Eclipse or rjmx. Having said that, the ones listed below can be moved without much difficulty:

  • org.openjdk.jmc.ui.common.action (3)
    Executable, IActionProvider, IUserAction

  • org.openjdk.jmc.ui.common.jvm (5)
    Connectable, JVMArch, JVMCommandLineToolkit, JVMDescriptor, JVMType

  • org.openjdk.jmc.ui.common.resource (2)
    IImageResource, Resource

  • org.openjdk.jmc.ui.common.security (10)
    ActionNotGrantedException, CredentialsNotAvailableException, FailedToSaveException, ICredentials, InMemoryCredentials, ISecurityManager, PersistentCredentials, SecurlyStoredByteArray, SecurityException, SecurityManagerFactory

  • org.opendjk.jmc.ui.common.tree (3)
    IArray, IChild, IParent

  • org.openjdk.jmc.ui.common.util (4)
    Environment, Filename, ICopyable, IObservable

  • org.openjdk.jmc.ui.common.xydata (5)
    DataSeries, DefautlTimestampedData, DefaultXYData, ITimeStampedData, IXYData

[0] https://bugs.openjdk.java.net/browse/JMC-7308


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7308: Move non-Eclipse dependant classes from org.openjdk.jmc.ui.common to org.openjdk.jmc.common

Reviewers

  • @bric3 (no known github.com user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/300/head:pull/300
$ git checkout pull/300

Update a local copy of the PR:
$ git checkout pull/300
$ git pull https://git.openjdk.java.net/jmc pull/300/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 300

View PR using the GUI difftool:
$ git pr show -t 300

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/300.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 9, 2021

👋 Welcome back aptmac! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 9, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 9, 2021

Webrevs

bric3
bric3 approved these changes Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants