Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7384: Add option to enable STARTTLS encryption for mail server in communication preference #303

Closed
wants to merge 1 commit into from

Conversation

Suchitainf
Copy link
Collaborator

@Suchitainf Suchitainf commented Aug 10, 2021

This PR addresses a new enhancement of adding the preference for STARTTLS encryption for the email communications triggered in JMX Console.

starttls


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7384: Add option to enable STARTTLS encryption for mail server in communication preference

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/303/head:pull/303
$ git checkout pull/303

Update a local copy of the PR:
$ git checkout pull/303
$ git pull https://git.openjdk.java.net/jmc pull/303/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 303

View PR using the GUI difftool:
$ git pr show -t 303

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/303.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 10, 2021

👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Aug 10, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 10, 2021

Webrevs

@guruhb
Copy link
Contributor

guruhb commented Aug 16, 2021

can we have Unit tests for these ? if possible Ui test as well ?

@thegreystone thegreystone requested a review from guruhb September 9, 2021 13:51
@openjdk
Copy link

openjdk bot commented Oct 1, 2021

@Suchitainf This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7384: Add option to enable STARTTLS encryption for mail server in communication preference

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • a0cbc98: 7336: Add support for new JFR event systemGC
  • d05f377: 7378: Update platform to 2021-06
  • 341f3d5: 7338: Add parser support for frame types generated by async-profiler
  • 2844db9: 7393: Add vanilla Java JSON serializer for IItemCollections
  • ff29931: 7332: Show stacktraces for constant values from stacktrace pool
  • 0e794a9: 7386: Remove reference to Fedora in the readme

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 1, 2021
@Suchitainf
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 4, 2021

Going to push as commit b447fd4.
Since your change was applied there have been 12 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 4, 2021
@openjdk
Copy link

openjdk bot commented Oct 4, 2021

@Suchitainf Pushed as commit b447fd4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants