Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7332: Show stacktraces for constant values from stacktrace pool #305

Closed
wants to merge 2 commits into from

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Sep 6, 2021

Replace the default Object.ToString of JfrStackTraces by the top frame
and linked to the StacktraceView for better visualization

Example:
Screenshot 2021-09-06 at 17 21 42


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7332: Show stacktraces for constant values from stacktrace pool

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/305/head:pull/305
$ git checkout pull/305

Update a local copy of the PR:
$ git checkout pull/305
$ git pull https://git.openjdk.java.net/jmc pull/305/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 305

View PR using the GUI difftool:
$ git pr show -t 305

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/305.diff

Replace the default Object.ToString of JfrStackTraces by the top frame
and linked to the StacktraceView for better visualization
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 6, 2021

👋 Welcome back jpbempel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 6, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 6, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 7, 2021

@jpbempel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7332: Show stacktraces for constant values from stacktrace pool

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 7, 2021
@jpbempel
Copy link
Member Author

jpbempel commented Sep 7, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 7, 2021

Going to push as commit ff29931.

@openjdk openjdk bot closed this Sep 7, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 7, 2021
@openjdk
Copy link

openjdk bot commented Sep 7, 2021

@jpbempel Pushed as commit ff29931.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jpbempel jpbempel deleted the 7332 branch September 9, 2021 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants