Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7336: Add support for new JFR event systemGC #307

Closed
wants to merge 2 commits into from

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Sep 15, 2021

SystemGC event brings stacktrace when a System.gc() is triggered
We can then correlate with GarbageCollection event with "System.gc()"
cause to this new event to be able to show stacktrace in Stacktrace
View/Flameview

Screenshot 2021-09-15 at 22 54 03


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7336: Add support for new JFR event systemGC

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/307/head:pull/307
$ git checkout pull/307

Update a local copy of the PR:
$ git checkout pull/307
$ git pull https://git.openjdk.java.net/jmc pull/307/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 307

View PR using the GUI difftool:
$ git pr show -t 307

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/307.diff

SystemGC event brings stacktrace when a System.gc() is triggered
We can then correlate with GarbageCollection event with "SystemGC"
cause to this new event to be able to show stacktrace in Stacktrace
View/Flameview
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2021

👋 Welcome back jpbempel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 15, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 23, 2021

@jpbempel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7336: Add support for new JFR event systemGC

Reviewed-by: aptmac, hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • d05f377: 7378: Update platform to 2021-06
  • 341f3d5: 7338: Add parser support for frame types generated by async-profiler

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 23, 2021
@jpbempel
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 27, 2021

Going to push as commit a0cbc98.
Since your change was applied there have been 2 commits pushed to the master branch:

  • d05f377: 7378: Update platform to 2021-06
  • 341f3d5: 7338: Add parser support for frame types generated by async-profiler

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 27, 2021
@openjdk
Copy link

openjdk bot commented Sep 27, 2021

@jpbempel Pushed as commit a0cbc98.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jpbempel jpbempel deleted the 7336 branch December 29, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants