7420: Update Japanese translation for rules #308

mohno007 · 2021-09-20T04:55:25Z

This PR updates/improves Japanese translation of rules and its descriptions.

Update

Update texts based on new commits to messages.properties made after the last update date of the messages_ja.properties.
- Support a new placeholder format introduced in Rule 2.0.
- Use Markdown style link.
- Add translations for newly added texts.
Update texts for translation correctness and understandability.
- Fix some wordings for understandability. Especially usage of Japanese particle.
- Add Japanese counter word (助数詞) for numeric value.

You can see decoded version of messages_ja using this script:

native2ascii -reverse core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties

Progress

Commit message must refer to an issue
Change must be properly reviewed

Issue

JMC-7420: Update Japanese translation for rules

Reviewers

Marcus Hirt (@thegreystone - Reviewer)
Alex Macdonald (@aptmac - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/308/head:pull/308
$ git checkout pull/308

Update a local copy of the PR:
$ git checkout pull/308
$ git pull https://git.openjdk.java.net/jmc pull/308/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 308

View PR using the GUI difftool:
$ git pr show -t 308

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/308.diff

Signed-off-by: Motohiro Ohno <m-ohno@atware.co.jp>

bridgekeeper · 2021-09-20T04:56:22Z

Hi @mohno007, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user mohno007" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

.../resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties

thegreystone · 2021-09-21T22:59:14Z

Thanks @mohno007! Let me know if you need any help with verifying the OCA status! Meanwhile, I've asked a friend in Japan to verify the texts.

mohno007 · 2021-09-22T17:35:03Z

Let me know if you need any help with verifying the OCA status!

I run into a problem with OCA.
I submitted the OCA application once but I wanted to change my email address, so I withdrew it and changed my email address.
Then I tried to submit the OCA application again, but I got an error which says the GitHub username is already in use.

I have already contacted Oracle Support by email and currently waiting for a response.

I've asked a friend in Japan to verify the texts.

Thank you.
I write Java code but I'm not very familiar with Java internals and its translation, so it would be very helpful if someone could check this translation.

thegreystone · 2021-09-22T20:29:23Z

I run into a problem with OCA.
I submitted the OCA application once but I wanted to change my email address, so I withdrew it and changed my email address.
Then I tried to submit the OCA application again, but I got an error which says the GitHub username is already in use.

@edvbld - can you help? What's the best way to help @mohno007 proceed with his application?

thegreystone · 2021-09-22T20:33:12Z

Hi @davidbuckjp! Any chance you could take a look at this?

thegreystone · 2021-10-01T17:01:37Z

I run into a problem with OCA. I submitted the OCA application once but I wanted to change my email address, so I withdrew it and changed my email address. Then I tried to submit the OCA application again, but I got an error which says the GitHub username is already in use.

I have already contacted Oracle Support by email and currently waiting for a response.

Have you heard back from Oracle Support yet?

robilad · 2021-10-01T19:36:08Z

Hi, please send me an e-Mail at dalibor.topic@oracle.com and I can try to assist you to find a resolution for the OCA issue.

thegreystone · 2021-10-04T09:12:28Z

Hi @mohno007! Just checking to see how things are going. Did you see @robilad's message?

mohno007 · 2021-10-05T13:10:29Z

@thegreystone

Hi @mohno007! Just checking to see how things are going. Did you see @robilad's message?

Thank you for the notice and sorry for the late reply, I just realized it and send a email.

thegreystone · 2021-11-30T18:15:20Z

Hi @robilad & @mohno007 - how is that application coming along? We're starting to ramp down 8.2.0 now.

mohno007 · 2022-01-14T12:36:08Z

/signed

bridgekeeper · 2022-01-14T12:37:12Z

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

mlbridge · 2022-01-20T23:33:11Z

Webrevs

01: Full - Incremental (ac631bd3)
00: Full (48d36d49)

thegreystone · 2022-01-21T12:12:39Z

/reviewers 2

openjdk · 2022-01-21T12:13:04Z

@thegreystone
The number of required reviews for this PR is now set to 2 (with at least 1 of role committers).

thegreystone

Needs an updated copyright year.

.../resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties

mohno007 · 2022-01-22T01:11:34Z

As you may know, I can sign the OCA.
Thank you to the developers for your patience.
Thank you to Dalibor-san and OCA support for resolving the issue.

openjdk · 2022-02-02T16:28:30Z

@mohno007 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7420: Update Japanese translation for rules

Reviewed-by: hirt, aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

1844ca4: 7486: Unable to install Eclipse IDE Plugin
e3549e9: 7532: Delay in realtime rendering of graphs in JMX Console
5fd290a: 6792: Outline shows as not available when starting up with open recording
7f42e4a: 7467: Only use one version of d3
9ec05b3: 7512: Update lz4-java and remove the osgi bundle name override
2f79156: 7421: Update Japanese translation for pages
87be29c: 7417: Fix incorrect identifier in result for biased locking revocation rule
f3ca1b1: 7539: JDP Tests failing in VPN environments
7037e74: 7541: Switch to using 2021-09 by default
3d03643: 7540: IItemCollectionJsonSerializerTest.java might fail on Windows due to line endings
... and 47 more: https://git.openjdk.java.net/jmc/compare/d05f377bdc5e4028db618e0d5f79c052136e1578...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone, @aptmac) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

thegreystone · 2022-02-02T17:33:45Z

Hi @mohno007! This PR is ready for integration! Please type /integrate in a new comment.

thegreystone · 2022-02-03T16:38:48Z

Also - @mohno007, are you in the JMC dev slack? If not, would you like to be? Please ping me, and I'd be happy to invite you.

thegreystone · 2022-02-08T16:09:21Z

Hi @mohno007 - a friendly reminder that this PR is ready for integration! Please write /integrate in a new comment in this PR to integrate.

mohno007 · 2022-02-15T06:41:10Z

/integrate

Thank you for reviewing and reminding me.

openjdk · 2022-02-15T06:41:58Z

@mohno007
Your change (at version ac631bd) is now ready to be sponsored by a Committer.

thegreystone · 2022-02-15T07:58:04Z

/sponsor

openjdk · 2022-02-15T07:59:08Z

Going to push as commit 0002999.
Since your change was applied there have been 57 commits pushed to the master branch:

1844ca4: 7486: Unable to install Eclipse IDE Plugin
e3549e9: 7532: Delay in realtime rendering of graphs in JMX Console
5fd290a: 6792: Outline shows as not available when starting up with open recording
7f42e4a: 7467: Only use one version of d3
9ec05b3: 7512: Update lz4-java and remove the osgi bundle name override
2f79156: 7421: Update Japanese translation for pages
87be29c: 7417: Fix incorrect identifier in result for biased locking revocation rule
f3ca1b1: 7539: JDP Tests failing in VPN environments
7037e74: 7541: Switch to using 2021-09 by default
3d03643: 7540: IItemCollectionJsonSerializerTest.java might fail on Windows due to line endings
... and 47 more: https://git.openjdk.java.net/jmc/compare/d05f377bdc5e4028db618e0d5f79c052136e1578...master

Your commit was automatically rebased without conflicts.

openjdk · 2022-02-15T07:59:28Z

@thegreystone @mohno007 Pushed as commit 0002999.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Update Japanese translation for rules

106b7c8

Signed-off-by: Motohiro Ohno <m-ohno@atware.co.jp>

bridgekeeper bot added the oca label Sep 20, 2021

thegreystone reviewed Sep 20, 2021

View reviewed changes

.../resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties Outdated Show resolved Hide resolved

fix copyright text

48d36d4

mohno007 force-pushed the rules_i18n_jp_update branch from fac9758 to 48d36d4 Compare September 21, 2021 02:26

thegreystone changed the title ~~Update Japanese translation for rules~~ 7420: Update Japanese translation for rules Oct 12, 2021

thegreystone added the hacktoberfest-accepted label Oct 21, 2021

bridgekeeper bot added the oca-verify label Jan 14, 2022

bridgekeeper bot removed oca oca-verify labels Jan 20, 2022

openjdk bot added the rfr label Jan 20, 2022

thegreystone self-requested a review January 21, 2022 12:09

thegreystone requested changes Jan 21, 2022

View reviewed changes

.../resources/org/openjdk/jmc/flightrecorder/rules/jdk/messages/internal/messages_ja.properties Outdated Show resolved Hide resolved

Update copyright year

ac631bd

mohno007 requested a review from thegreystone January 22, 2022 01:39

thegreystone approved these changes Jan 24, 2022

View reviewed changes

thegreystone requested a review from aptmac January 24, 2022 20:12

aptmac approved these changes Feb 2, 2022

View reviewed changes

openjdk bot added the ready label Feb 2, 2022

openjdk bot added the sponsor label Feb 15, 2022

openjdk bot added the integrated label Feb 15, 2022

openjdk bot closed this Feb 15, 2022

openjdk bot removed ready rfr sponsor labels Feb 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

7420: Update Japanese translation for rules #308

7420: Update Japanese translation for rules #308

mohno007 commented Sep 20, 2021 •

edited by openjdk bot

Loading

bridgekeeper bot commented Sep 20, 2021

thegreystone commented Sep 21, 2021

mohno007 commented Sep 22, 2021

thegreystone commented Sep 22, 2021

thegreystone commented Sep 22, 2021

thegreystone commented Oct 1, 2021

robilad commented Oct 1, 2021

thegreystone commented Oct 4, 2021

mohno007 commented Oct 5, 2021 •

edited

Loading

thegreystone commented Nov 30, 2021

mohno007 commented Jan 14, 2022

bridgekeeper bot commented Jan 14, 2022

mlbridge bot commented Jan 20, 2022 •

edited

Loading

thegreystone commented Jan 21, 2022

openjdk bot commented Jan 21, 2022

thegreystone left a comment

mohno007 commented Jan 22, 2022 •

edited

Loading

openjdk bot commented Feb 2, 2022 •

edited

Loading

thegreystone commented Feb 2, 2022

thegreystone commented Feb 3, 2022

thegreystone commented Feb 8, 2022

mohno007 commented Feb 15, 2022

openjdk bot commented Feb 15, 2022

thegreystone commented Feb 15, 2022

openjdk bot commented Feb 15, 2022

openjdk bot commented Feb 15, 2022

7420: Update Japanese translation for rules #308

7420: Update Japanese translation for rules #308

Conversation

mohno007 commented Sep 20, 2021 • edited by openjdk bot Loading

Update

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Sep 20, 2021

thegreystone commented Sep 21, 2021

mohno007 commented Sep 22, 2021

thegreystone commented Sep 22, 2021

thegreystone commented Sep 22, 2021

thegreystone commented Oct 1, 2021

robilad commented Oct 1, 2021

thegreystone commented Oct 4, 2021

mohno007 commented Oct 5, 2021 • edited Loading

thegreystone commented Nov 30, 2021

mohno007 commented Jan 14, 2022

bridgekeeper bot commented Jan 14, 2022

mlbridge bot commented Jan 20, 2022 • edited Loading

Webrevs

thegreystone commented Jan 21, 2022

openjdk bot commented Jan 21, 2022

thegreystone left a comment

Choose a reason for hiding this comment

mohno007 commented Jan 22, 2022 • edited Loading

openjdk bot commented Feb 2, 2022 • edited Loading

thegreystone commented Feb 2, 2022

thegreystone commented Feb 3, 2022

thegreystone commented Feb 8, 2022

mohno007 commented Feb 15, 2022

openjdk bot commented Feb 15, 2022

thegreystone commented Feb 15, 2022

openjdk bot commented Feb 15, 2022

openjdk bot commented Feb 15, 2022

mohno007 commented Sep 20, 2021 •

edited by openjdk bot

Loading

mohno007 commented Oct 5, 2021 •

edited

Loading

mlbridge bot commented Jan 20, 2022 •

edited

Loading

mohno007 commented Jan 22, 2022 •

edited

Loading

openjdk bot commented Feb 2, 2022 •

edited

Loading