7417: Fix incorrect identifier in result for biased locking revocation rule

[mohno007]

This PR fixes a wrong placeholder in BiasedLockingRevocationRule_TEXT_REVOKED_CLASSES_FOUND_LONG.

BiasedLockingRevocationRule.java used {revokedClasses} for placeholder identifier but messages.properties used {revokedTypes}.

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JMC-7417: Fix incorrect identifier in result for biased locking revocation rule

Reviewers

• Alex Macdonald (@aptmac - Reviewer) ⚠️ Review applies to 24db383
• Marcus Hirt (@thegreystone - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/309/head:pull/309
$ git checkout pull/309

Update a local copy of the PR:
$ git checkout pull/309
$ git pull https://git.openjdk.java.net/jmc pull/309/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 309

View PR using the GUI difftool:
$ git pr show -t 309

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/309.diff

[bridgekeeper]

Hi @mohno007, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user mohno007" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[thegreystone]

Looks good @mohno007! Please follow the instructions of the bot to get your OCA status set straight.

[thegreystone]

Hi @mohno007! Just checking on how things are going with the OCA. Can I help?

[Gunde]

Please edit the title to refer to JMC-7417 by adding changing the title to "7417:Fix incorrect identifier in result for biased locking revocation rule". And when the OCA status is fixed I'll be happy to approve this PR.

[thegreystone]

@mohno007 / @robilad - any news on the OCA?

[thegreystone]

Hi @robilad & @mohno007 - how is that application coming along? We're starting to ramp down 8.2.0 now.

[mohno007]

/signed

[bridgekeeper]

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[openjdk]

@mohno007 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7417: Fix incorrect identifier in result for biased locking revocation rule

Reviewed-by: aptmac, hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• f3ca1b1: 7539: JDP Tests failing in VPN environments
• 7037e74: 7541: Switch to using 2021-09 by default
• 3d03643: 7540: IItemCollectionJsonSerializerTest.java might fail on Windows due to line endings
• baa6c77: 7537: Build script assumes that Darwin always targets x86_64
• c646b14: 7477: JMC8.2 does not build with eclipse 4.19 (21-03)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aptmac, @thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 01: Full (ecb74c72)
• 00: Full (24db3838)

[thegreystone]

/reviewers 2

[openjdk]

@thegreystone
The number of required reviews for this PR is now set to 2 (with at least 1 of role committers).

[openjdk]

@mohno007 this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout revoke_types
git fetch https://git.openjdk.java.net/jmc master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[thegreystone]

@mohno007 - please integrate your changes by writing /integrate in a comment.

[mohno007]

/integrate

[openjdk]

@mohno007
Your change (at version ecb74c7) is now ready to be sponsored by a Committer.

[thegreystone]

/sponsor

[openjdk]

Going to push as commit 87be29c.
Since your change was applied there have been 5 commits pushed to the master branch:

• f3ca1b1: 7539: JDP Tests failing in VPN environments
• 7037e74: 7541: Switch to using 2021-09 by default
• 3d03643: 7540: IItemCollectionJsonSerializerTest.java might fail on Windows due to line endings
• baa6c77: 7537: Build script assumes that Darwin always targets x86_64
• c646b14: 7477: JMC8.2 does not build with eclipse 4.19 (21-03)

Your commit was automatically rebased without conflicts.

[openjdk]

@thegreystone @mohno007 Pushed as commit 87be29c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.