Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6674: Optimize finding of first start time and first & last end times #31

Closed
wants to merge 8 commits into from
@@ -1369,7 +1369,7 @@ public int compare(Map.Entry<String, Integer> o1, Map.Entry<String, Integer> o2)

/**
* Returns the earliest start time in the provided item collection. This method is based on the
* assumption that item collection lanes are sorted by timestamps.
* assumption that item collection lanes are sorted by timestamp.
*
* @param items
* the item collection to find the earliest start time in
@@ -1398,12 +1398,12 @@ public static IQuantity getEarliestStartTime(IItemCollection items) {
}

/**
* Returns the earliest start time in the provided item collection. This method is based on the
* assumption that item collection lanes are sorted by timestamps.
* Returns the earliest end time in the provided item collection. This method is based on the
* assumption that item collection lanes are sorted by timestamp.
This conversation was marked as resolved by Gunde

This comment has been minimized.

Copy link
@thegreystone

thegreystone Jan 20, 2020

Collaborator

...and that they are not overlapping.

*
* @param items
* the item collection to find the earliest start time in
* @return the earliest start time in the provided collection
* the item collection to find the earliest end time in
* @return the earliest end time in the provided collection
*/
public static IQuantity getEarliestEndTime(IItemCollection items) {
IQuantity earliestEndTime = null;
@@ -1429,7 +1429,7 @@ public static IQuantity getEarliestEndTime(IItemCollection items) {

/**
* Returns the latest end time in the provided item collection. This method is based on the
* assumption that item collection lanes are sorted by timestamps.
* assumption that item collection lanes are sorted by timestamp.
This conversation was marked as resolved by Gunde

This comment has been minimized.

Copy link
@thegreystone

thegreystone Jan 20, 2020

Collaborator

...and that they are not overlapping.

*
* @param items
* the item collection to find the latest end time in
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.