-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7421: Update Japanese translation for pages #310
Conversation
Hi @mohno007, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user mohno007" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
Hi @davidbuckjp! Any chance you could take a look at this? |
...rc/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties
Outdated
Show resolved
Hide resolved
Hi @davidbuckjp, any chance you can take a look at this whilst the OCA problems are being looked at? |
Hi @robilad, @davidbuckjp & @edvbld! Is there anything that can be done to help @mohno007 get his OCA through? We're entering RDP2 for JMC 8.2.0, and I'd really like to take these PRs. |
/signed |
Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
Hi @robilad! Any chance the OCA will be processed soon? |
@mohno007 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 50 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aptmac, @thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
...rc/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties
Outdated
Show resolved
Hide resolved
/reviewers 2 |
@thegreystone |
@mohno007 - please integrate your changes by writing /integrate in a comment. |
/integrate |
/sponsor |
Thank you @mohno007! :) |
Going to push as commit 2f79156.
Your commit was automatically rebased without conflicts. |
@thegreystone @mohno007 Pushed as commit 2f79156. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR updates/improves Japanese translation for pages.
Update texts based on new commits to
messages.properties
made after the last update date of themessages_ja.properties
.You can see decoded version of
messages_ja
using this script:Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/310/head:pull/310
$ git checkout pull/310
Update a local copy of the PR:
$ git checkout pull/310
$ git pull https://git.openjdk.java.net/jmc pull/310/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 310
View PR using the GUI difftool:
$ git pr show -t 310
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/310.diff