Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7421: Update Japanese translation for pages #310

Closed
wants to merge 4 commits into from

Conversation

mohno007
Copy link
Contributor

@mohno007 mohno007 commented Sep 20, 2021

This PR updates/improves Japanese translation for pages.

Update texts based on new commits to messages.properties made after the last update date of the messages_ja.properties.

You can see decoded version of messages_ja using this script:

native2ascii -reverse application/l10n/org.openjdk.jmc.flightrecorder.ui.ja/src/main/resources/org/openjdk/jmc/flightrecorder/ui/messages/internal/messages_ja.properties

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7421: Update Japanese translation for pages

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/310/head:pull/310
$ git checkout pull/310

Update a local copy of the PR:
$ git checkout pull/310
$ git pull https://git.openjdk.java.net/jmc pull/310/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 310

View PR using the GUI difftool:
$ git pr show -t 310

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/310.diff

@bridgekeeper bridgekeeper bot added the oca label Sep 20, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2021

Hi @mohno007, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user mohno007" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@thegreystone
Copy link
Member

Hi @davidbuckjp! Any chance you could take a look at this?

@thegreystone thegreystone changed the title Update Japanese translation for pages 7421: Update Japanese translation for pages Oct 12, 2021
@thegreystone
Copy link
Member

Hi @robilad & @mohno007 - how is that application coming along? We're starting to ramp down 8.2.0 now.

@thegreystone
Copy link
Member

Hi @davidbuckjp, any chance you can take a look at this whilst the OCA problems are being looked at?

@thegreystone
Copy link
Member

Hi @robilad, @davidbuckjp & @edvbld! Is there anything that can be done to help @mohno007 get his OCA through? We're entering RDP2 for JMC 8.2.0, and I'd really like to take these PRs.

@mohno007
Copy link
Contributor Author

/signed

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 16, 2022

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@thegreystone
Copy link
Member

Hi @robilad! Any chance the OCA will be processed soon?

@openjdk
Copy link

openjdk bot commented Jan 20, 2022

@mohno007 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7421: Update Japanese translation for pages

Reviewed-by: aptmac, hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aptmac, @thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

mlbridge bot commented Jan 20, 2022

Webrevs

@thegreystone
Copy link
Member

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jan 21, 2022

@thegreystone
The number of required reviews for this PR is now set to 2 (with at least 1 of role committers).

@openjdk openjdk bot removed the ready label Jan 21, 2022
@mohno007 mohno007 requested a review from thegreystone January 22, 2022 01:39
@openjdk openjdk bot added the ready label Jan 24, 2022
@thegreystone
Copy link
Member

@mohno007 - please integrate your changes by writing /integrate in a comment.

@mohno007
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor label Jan 25, 2022
@openjdk
Copy link

openjdk bot commented Jan 25, 2022

@mohno007
Your change (at version 3fdce40) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

/sponsor

@thegreystone
Copy link
Member

Thank you @mohno007! :)

@openjdk
Copy link

openjdk bot commented Jan 25, 2022

Going to push as commit 2f79156.
Since your change was applied there have been 51 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

openjdk bot commented Jan 25, 2022

@thegreystone @mohno007 Pushed as commit 2f79156.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants