Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7403: Fix JFR Parser struct types hashcode #313

Closed
wants to merge 2 commits into from

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Oct 2, 2021


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7403: Fix JFR Parser struct types hashcode

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/313/head:pull/313
$ git checkout pull/313

Update a local copy of the PR:
$ git checkout pull/313
$ git pull https://git.openjdk.java.net/jmc pull/313/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 313

View PR using the GUI difftool:
$ git pr show -t 313

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/313.diff

@thegreystone thegreystone requested a review from jbachorik Oct 2, 2021
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 2, 2021

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@thegreystone thegreystone marked this pull request as ready for review Oct 4, 2021
@thegreystone thegreystone requested review from jpbempel and Gunde Oct 4, 2021
@openjdk openjdk bot added the rfr label Oct 4, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 4, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2021

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7403: Fix JFR Parser struct types hashcode

Reviewed-by: jbachorik, jpbempel

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • fea3787: 7415: Fix Maven prerequisite in README
  • 14b8357: 7414: Avoid volatile writes from Atomics default values
  • 085a4a6: 7413: Fix building JMC with Docker

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 4, 2021
@thegreystone
Copy link
Member Author

@thegreystone thegreystone commented Oct 4, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2021

Going to push as commit 90165cf.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 4d413ee: 7411: GPG signing in Github action fails
  • 01fb898: 7412: Update the jacoco maven plugin
  • fea3787: 7415: Fix Maven prerequisite in README
  • 14b8357: 7414: Avoid volatile writes from Atomics default values
  • 085a4a6: 7413: Fix building JMC with Docker

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2021

@thegreystone Pushed as commit 90165cf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants