Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7411: GPG signing in Github action fails #314

Closed
wants to merge 1 commit into from

Conversation

reinhapa
Copy link
Member

@reinhapa reinhapa commented Oct 2, 2021

Signed-off-by: Patrick Reinhart patrick@reini.net


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7411: GPG signing in Github action fails

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/314/head:pull/314
$ git checkout pull/314

Update a local copy of the PR:
$ git checkout pull/314
$ git pull https://git.openjdk.java.net/jmc pull/314/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 314

View PR using the GUI difftool:
$ git pr show -t 314

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/314.diff

Signed-off-by: Patrick Reinhart <patrick@reini.net>
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2021

👋 Welcome back reinhapa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 2, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 2, 2021

Webrevs

Copy link
Collaborator

@bric3 bric3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Although I would add a comment that pinentry is a program that is used to interact with the user to enter the passphrase which is not possible with Github Actions of course.

@openjdk
Copy link

openjdk bot commented Oct 4, 2021

@reinhapa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7411: GPG signing in Github action fails

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • fea3787: 7415: Fix Maven prerequisite in README
  • 14b8357: 7414: Avoid volatile writes from Atomics default values
  • 085a4a6: 7413: Fix building JMC with Docker

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 4, 2021
@reinhapa
Copy link
Member Author

reinhapa commented Oct 4, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 4, 2021
@openjdk
Copy link

openjdk bot commented Oct 4, 2021

@reinhapa
Your change (at version 9e22141) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 4, 2021

Going to push as commit 4d413ee.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 01fb898: 7412: Update the jacoco maven plugin
  • fea3787: 7415: Fix Maven prerequisite in README
  • 14b8357: 7414: Avoid volatile writes from Atomics default values
  • 085a4a6: 7413: Fix building JMC with Docker

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 4, 2021
@openjdk
Copy link

openjdk bot commented Oct 4, 2021

@thegreystone @reinhapa Pushed as commit 4d413ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@reinhapa reinhapa deleted the jmc7411 branch October 4, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants