Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7413: Fix building JMC with Docker #317

Closed
wants to merge 1 commit into from

Conversation

dreis2211
Copy link
Contributor

@dreis2211 dreis2211 commented Oct 2, 2021

Hi,

I noticed that the Docker builds still point to JDK 8 and thus fail with messages like the following.

Caused by: java.lang.UnsupportedClassVersionError: org/eclipse/tycho/core/maven/TychoMavenLifecycleParticipant has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

This PR therefore upgrades the Docker images to newer JDK 11 images, which fixes the issues described.

This would need a ticket in the bug tracker and I hope you can create this for me. OCA should be signed already, but let me know if I need to confirm something again.

In case you think this is worthwhile, I would appreciate it if this is sponsored.

Cheers,
Christoph


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7413: Fix building JMC with Docker

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/317/head:pull/317
$ git checkout pull/317

Update a local copy of the PR:
$ git checkout pull/317
$ git pull https://git.openjdk.java.net/jmc pull/317/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 317

View PR using the GUI difftool:
$ git pr show -t 317

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/317.diff

@thegreystone thegreystone changed the title Fix building JMC with Docker 7413: Fix building JMC with Docker Oct 2, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2021

👋 Welcome back dreis2211! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 4, 2021

@dreis2211 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7413: Fix building JMC with Docker

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

mlbridge bot commented Oct 4, 2021

Webrevs

@thegreystone
Copy link
Member

@dreis2211 - you can /integrate the changes now.

@dreis2211
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor label Oct 4, 2021
@openjdk
Copy link

openjdk bot commented Oct 4, 2021

@dreis2211
Your change (at version 70c458b) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 4, 2021

Going to push as commit 085a4a6.

@openjdk openjdk bot closed this Oct 4, 2021
@openjdk
Copy link

openjdk bot commented Oct 4, 2021

@thegreystone @dreis2211 Pushed as commit 085a4a6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants