-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7413: Fix building JMC with Docker #317
Conversation
👋 Welcome back dreis2211! A progress list of the required criteria for merging this PR into |
@dreis2211 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@dreis2211 - you can /integrate the changes now. |
/integrate |
@dreis2211 |
/sponsor |
Going to push as commit 085a4a6. |
@thegreystone @dreis2211 Pushed as commit 085a4a6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
I noticed that the Docker builds still point to JDK 8 and thus fail with messages like the following.
This PR therefore upgrades the Docker images to newer JDK 11 images, which fixes the issues described.
This would need a ticket in the bug tracker and I hope you can create this for me. OCA should be signed already, but let me know if I need to confirm something again.
In case you think this is worthwhile, I would appreciate it if this is sponsored.
Cheers,
Christoph
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/317/head:pull/317
$ git checkout pull/317
Update a local copy of the PR:
$ git checkout pull/317
$ git pull https://git.openjdk.java.net/jmc pull/317/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 317
View PR using the GUI difftool:
$ git pr show -t 317
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/317.diff