-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7415: Fix Maven prerequisite in README #318
Conversation
👋 Welcome back dreis2211! A progress list of the required criteria for merging this PR into |
@dreis2211 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@dreis2211 |
/sponsor |
@thegreystone @dreis2211 Pushed as commit fea3787. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi,
I just noticed that the minimum Maven prerequisite is wrong in the README. CI-friendly versions like
revision
andchangelist
are a feature of3.5.x
and thus3.3.x
is not sufficient anymore.I hope you can create a ticket for me and sponsor this.
Cheers,
Christoph
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/318/head:pull/318
$ git checkout pull/318
Update a local copy of the PR:
$ git checkout pull/318
$ git pull https://git.openjdk.java.net/jmc pull/318/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 318
View PR using the GUI difftool:
$ git pr show -t 318
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/318.diff