Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7415: Fix Maven prerequisite in README #318

Closed
wants to merge 1 commit into from

Conversation

dreis2211
Copy link
Contributor

@dreis2211 dreis2211 commented Oct 4, 2021

Hi,

I just noticed that the minimum Maven prerequisite is wrong in the README. CI-friendly versions like revision and changelist are a feature of 3.5.x and thus 3.3.x is not sufficient anymore.

I hope you can create a ticket for me and sponsor this.

Cheers,
Christoph


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7415: Fix Maven prerequisite in README

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/318/head:pull/318
$ git checkout pull/318

Update a local copy of the PR:
$ git checkout pull/318
$ git pull https://git.openjdk.java.net/jmc pull/318/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 318

View PR using the GUI difftool:
$ git pr show -t 318

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/318.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2021

👋 Welcome back dreis2211! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@thegreystone thegreystone changed the title Fix Maven prerequisite in README 7415: Fix Maven prerequisite in README Oct 4, 2021
@openjdk openjdk bot added the rfr label Oct 4, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 4, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 4, 2021

@dreis2211 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7415: Fix Maven prerequisite in README

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 14b8357: 7414: Avoid volatile writes from Atomics default values

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@dreis2211
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor label Oct 4, 2021
@openjdk
Copy link

openjdk bot commented Oct 4, 2021

@dreis2211
Your change (at version 072795d) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 4, 2021

Going to push as commit fea3787.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 14b8357: 7414: Avoid volatile writes from Atomics default values

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 4, 2021
@openjdk
Copy link

openjdk bot commented Oct 4, 2021

@thegreystone @dreis2211 Pushed as commit fea3787.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants