Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7418: Stop using Collections sort method #319

Closed

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Oct 8, 2021

Since JDK 8, the collections themselves have a sort method. Might as well start using it. ;)


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7418: Stop using Collections sort method

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/319/head:pull/319
$ git checkout pull/319

Update a local copy of the PR:
$ git checkout pull/319
$ git pull https://git.openjdk.java.net/jmc pull/319/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 319

View PR using the GUI difftool:
$ git pr show -t 319

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/319.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 8, 2021

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 8, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 8, 2021

Webrevs

@thegreystone thegreystone requested a review from Gunde October 12, 2021 18:06
@openjdk
Copy link

openjdk bot commented Oct 20, 2021

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7418: Stop using Collections sort method

Reviewed-by: aptmac, hdafgard

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • ef36b79: 7437: Fix require bundle error in Eclipse
  • 1d17e0c: 7435: Update the maven enforcer plugin
  • cf4ceb3: 7434: Update the maven download plugin
  • 9bb5799: 7433: Update the spotless maven plugin
  • 5787b9a: 7091: JOverflow Instance View table should be sortable by clicking headers
  • c725078: 7231: JMC createReport for JMC8 Automated Analysis fails to evaluate several rules
  • 90197d6: 7419: Update XML parsing

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@thegreystone
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 26, 2021

Going to push as commit 77580fe.
Since your change was applied there have been 7 commits pushed to the master branch:

  • ef36b79: 7437: Fix require bundle error in Eclipse
  • 1d17e0c: 7435: Update the maven enforcer plugin
  • cf4ceb3: 7434: Update the maven download plugin
  • 9bb5799: 7433: Update the spotless maven plugin
  • 5787b9a: 7091: JOverflow Instance View table should be sortable by clicking headers
  • c725078: 7231: JMC createReport for JMC8 Automated Analysis fails to evaluate several rules
  • 90197d6: 7419: Update XML parsing

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 26, 2021
@openjdk
Copy link

openjdk bot commented Oct 26, 2021

@thegreystone Pushed as commit 77580fe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@thegreystone thegreystone deleted the 7418-no-collections-sort branch October 16, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants