Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6660: Make JMX API not return classes #32

Closed
wants to merge 1 commit into from

Conversation

jessyec-s
Copy link
Contributor

@jessyec-s jessyec-s commented Jan 15, 2020

This patch modifies the JMX API so that functions return void instead of class arrays.

The name of the function setTransforms was also changed to defineEventProbes as a result of this change because an mbean function whose name begins with "set", has one parameter and a return type of void, gets registered as a setter not an operation.

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JMC-6660: Agent JMX API should not return classes

Approvers

  • Marcus Hirt (hirt - Reviewer)

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 15, 2020

👋 Welcome back jessyec-s! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Jan 15, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 15, 2020

Webrevs

@openjdk openjdk bot removed the rfr label Jan 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 17, 2020

@jessyec-s This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6660: Make JMX API not return classes

Reviewed-by: hirt
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge master into your branch first.

As you are not a known OpenJDK Author, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jan 17, 2020
@jessyec-s
Copy link
Contributor Author

@jessyec-s jessyec-s commented Jan 17, 2020

/integrate

@openjdk openjdk bot added the sponsor label Jan 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 17, 2020

@jessyec-s
Your change (at version e935d42) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

@thegreystone thegreystone commented Jan 17, 2020

/sponsor

@openjdk openjdk bot closed this Jan 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jan 17, 2020

@thegreystone @jessyec-s The following commits have been pushed to master since your change was applied:

  • ea933fa: 6674: Use try-with-resource in more places and close un-closed resources
  • 8790592: 6668: Move org.openjdk.jmc.jdp bundle from application to core
  • f74caa8: 6549: Color flame chart based on package name

Your commit was automatically rebased without conflicts.

Pushed as commit afcf74d.

@jessyec-s jessyec-s deleted the jmc-6660 branch Jan 17, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 17, 2020

Mailing list message from Marcus Hirt on jmc-dev:

Changeset: afcf74d
Author: Jessye Coleman-Shapiro <jescolem at redhat.com>
Committer: Marcus Hirt <hirt at openjdk.org>
Date: 2020-01-17 20:04:53 +0000
URL: https://git.openjdk.java.net/jmc/commit/afcf74db

6660: Make JMX API not return classes

Reviewed-by: hirt

! core/org.openjdk.jmc.agent/README.md
! core/org.openjdk.jmc.agent/pom.xml
! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jmx/AgentController.java
! core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jmx/AgentControllerMBean.java
+ core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/TestDefineEventProbes.java
- core/org.openjdk.jmc.agent/src/test/java/org/openjdk/jmc/agent/test/TestSetTransforms.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants