Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7419: Update XML parsing #320

Closed
wants to merge 2 commits into from
Closed

7419: Update XML parsing #320

wants to merge 2 commits into from

Conversation

eastig
Copy link
Member

@eastig eastig commented Oct 12, 2021

This patch fixes JMC-7419.
Testing: man verify


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/320/head:pull/320
$ git checkout pull/320

Update a local copy of the PR:
$ git checkout pull/320
$ git pull https://git.openjdk.java.net/jmc pull/320/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 320

View PR using the GUI difftool:
$ git pr show -t 320

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/320.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 12, 2021

👋 Welcome back eastig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 12, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 12, 2021

Webrevs

@eastig eastig changed the title 7419: Insecure XML parsing: XXE injection 7419: Update XML parsing Oct 12, 2021
@openjdk
Copy link

openjdk bot commented Oct 12, 2021

@eastig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7419: Update XML parsing

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 12, 2021
@eastig
Copy link
Member Author

eastig commented Oct 12, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 12, 2021
@openjdk
Copy link

openjdk bot commented Oct 12, 2021

@eastig
Your change (at version 9ef7ce0) is now ready to be sponsored by a Committer.

@eastig
Copy link
Member Author

eastig commented Oct 12, 2021

@thegreystone Thank you for reviewing.

@openjdk openjdk bot removed the sponsor label Oct 12, 2021
@thegreystone thegreystone self-requested a review October 13, 2021 00:06
@thegreystone
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@thegreystone The PR has been updated since the change author (@eastig) issued the integrate command - the author must perform this command again.

@thegreystone
Copy link
Member

@eastig - can you please integrate again?

@eastig
Copy link
Member Author

eastig commented Oct 13, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 13, 2021
@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@eastig
Your change (at version 66291a6) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 13, 2021

Going to push as commit 90197d6.

@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@thegreystone @eastig Pushed as commit 90197d6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants