-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7419: Update XML parsing #320
Conversation
👋 Welcome back eastig! A progress list of the required criteria for merging this PR into |
Webrevs
|
@eastig This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@thegreystone Thank you for reviewing. |
/sponsor |
@thegreystone The PR has been updated since the change author (@eastig) issued the |
@eastig - can you please integrate again? |
/integrate |
/sponsor |
Going to push as commit 90197d6. |
@thegreystone @eastig Pushed as commit 90197d6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This patch fixes JMC-7419.
Testing:
man verify
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/320/head:pull/320
$ git checkout pull/320
Update a local copy of the PR:
$ git checkout pull/320
$ git pull https://git.openjdk.java.net/jmc pull/320/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 320
View PR using the GUI difftool:
$ git pr show -t 320
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/320.diff