7091: JOverflow Instance View table should be sortable by clicking headers #322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses JMC-7091 [0], in which the tree viewer in the JOverflow instances tab does not allow the table to be sorted via the column headers. Currently the viewer column headers do not perform any action when clicked. Now a comparator have been added to the viewer which sorts based on the column header (String comparison for the Name & Value columns, Integer for the Size column).
Screenshot:
Gif:
[0] https://bugs.openjdk.java.net/browse/JMC-7091
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/322/head:pull/322
$ git checkout pull/322
Update a local copy of the PR:
$ git checkout pull/322
$ git pull https://git.openjdk.java.net/jmc pull/322/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 322
View PR using the GUI difftool:
$ git pr show -t 322
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/322.diff