Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7091: JOverflow Instance View table should be sortable by clicking headers #322

Closed
wants to merge 1 commit into from

Conversation

aptmac
Copy link
Member

@aptmac aptmac commented Oct 15, 2021

This PR addresses JMC-7091 [0], in which the tree viewer in the JOverflow instances tab does not allow the table to be sorted via the column headers. Currently the viewer column headers do not perform any action when clicked. Now a comparator have been added to the viewer which sorts based on the column header (String comparison for the Name & Value columns, Integer for the Size column).

Screenshot:
2021-10-14-142941_1074x516_scrot

Gif:
7091

[0] https://bugs.openjdk.java.net/browse/JMC-7091


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7091: JOverflow Instance View table should be sortable by clicking headers

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/322/head:pull/322
$ git checkout pull/322

Update a local copy of the PR:
$ git checkout pull/322
$ git pull https://git.openjdk.java.net/jmc pull/322/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 322

View PR using the GUI difftool:
$ git pr show -t 322

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/322.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 15, 2021

👋 Welcome back aptmac! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 15, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 15, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 16, 2021

@aptmac This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7091: JOverflow Instance View table should be sortable by clicking headers

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 16, 2021
@aptmac
Copy link
Member Author

aptmac commented Oct 18, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Oct 18, 2021

Going to push as commit 5787b9a.

@openjdk openjdk bot closed this Oct 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 18, 2021
@openjdk
Copy link

openjdk bot commented Oct 18, 2021

@aptmac Pushed as commit 5787b9a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aptmac aptmac deleted the 7091 branch December 6, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants