Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7437: Fix require bundle error in Eclipse #331

Closed

Conversation

thegreystone
Copy link
Member

@thegreystone thegreystone commented Oct 22, 2021

Removing extra comma making Eclipse complain.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7437: Fix require bundle error in Eclipse

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/331/head:pull/331
$ git checkout pull/331

Update a local copy of the PR:
$ git checkout pull/331
$ git pull https://git.openjdk.java.net/jmc pull/331/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 331

View PR using the GUI difftool:
$ git pr show -t 331

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/331.diff

@thegreystone thegreystone requested a review from aptmac October 22, 2021 18:58
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 22, 2021

👋 Welcome back hirt! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Oct 22, 2021
@thegreystone thegreystone requested a review from Gunde October 22, 2021 19:01
@mlbridge
Copy link

mlbridge bot commented Oct 22, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 22, 2021

@thegreystone This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7437: Fix require bundle error in Eclipse

Reviewed-by: aptmac, hdafgard

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 22, 2021
@thegreystone
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 26, 2021

Going to push as commit ef36b79.

@openjdk openjdk bot closed this Oct 26, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 26, 2021
@openjdk
Copy link

openjdk bot commented Oct 26, 2021

@thegreystone Pushed as commit ef36b79.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@thegreystone thegreystone deleted the 7437-require-bundle-error branch October 16, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants