Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7440: JMC fails on Apple M1 #334

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link

@omikhaltsova omikhaltsova commented Nov 20, 2021

I would like to add support for the macOS AArch64 platform to JMC.
Please review this change!

Our build for macOS AArch64 can be downloaded from here:
https://www.azul.com/products/components/zulu-mission-control/#block-download


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/334/head:pull/334
$ git checkout pull/334

Update a local copy of the PR:
$ git checkout pull/334
$ git pull https://git.openjdk.java.net/jmc pull/334/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 334

View PR using the GUI difftool:
$ git pr show -t 334

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/334.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 20, 2021
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 20, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7440: JMC fails on Apple M1

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Nov 20, 2021
@omikhaltsova
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor label Nov 22, 2021
@openjdk
Copy link

openjdk bot commented Nov 22, 2021

@omikhaltsova
Your change (at version f5680a6) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 24, 2021

Going to push as commit d218205.

@openjdk
Copy link

openjdk bot commented Nov 24, 2021

@thegreystone @omikhaltsova Pushed as commit d218205.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants