7463: JfrEditor instances are kept in memory by NavigationHistory

[jpbempel]

Provide a sub class of NavigationHistory instead of implementing a
full INavigationHistory.
JfrEditor is not kept anymore when releasing state/disposing.

Provide a sub class of NavigationHistory instead of implementing a
full INavigationHistory.
JfrEditor is not kept anymore when releasing state/disposing.

JMC 8.1, opening 13 recordings, then closing them:

COMP11909:~/git/jmc-jpbempel$ jcmd 55089 GC.heap_info
55089:
 garbage-first heap   total 989184K, used 488772K [0x0000000700000000, 0x0000000800000000)
  region size 1024K, 1 young (1024K), 0 survivors (0K)
 Metaspace       used 60486K, capacity 65423K, committed 65584K, reserved 1105920K
  class space    used 6822K, capacity 8453K, committed 8576K, reserved 1048576K
COMP11909:~/git/jmc-jpbempel$ jcmd 55089 GC.run
55089:
Command executed successfully
COMP11909:~/git/jmc-jpbempel$ jcmd 55089 GC.heap_info
55089:
 garbage-first heap   total 989184K, used 488410K [0x0000000700000000, 0x0000000800000000)
  region size 1024K, 1 young (1024K), 0 survivors (0K)
 Metaspace       used 61621K, capacity 66457K, committed 66736K, reserved 1107968K
  class space    used 6938K, capacity 8583K, committed 8704K, reserved 1048576K

memory is not released even after GC

JMC 8.2 + fix:

COMP11909:~/git/jmc-jpbempel$ jcmd 56259 GC.heap_info
56259:
 garbage-first heap   total 1625088K, used 556392K [0x0000000700000000, 0x0000000800000000)
  region size 1024K, 1 young (1024K), 0 survivors (0K)
 Metaspace       used 61931K, capacity 66724K, committed 66992K, reserved 1107968K
  class space    used 6991K, capacity 8586K, committed 8704K, reserved 1048576K
COMP11909:~/git/jmc-jpbempel$ jcmd 56259 GC.run
56259:
Command executed successfully
COMP11909:~/git/jmc-jpbempel$ jcmd 56259 GC.heap_info
56259:
 garbage-first heap   total 109568K, used 28592K [0x0000000700000000, 0x0000000800000000)
  region size 1024K, 1 young (1024K), 0 survivors (0K)
 Metaspace       used 62269K, capacity 67053K, committed 67248K, reserved 1107968K
  class space    used 6994K, capacity 8588K, committed 8704K, reserved 1048576K

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JMC-7463: JfrEditor instances are kept in memory by NavigationHistory

Reviewers

• Marcus Hirt (@thegreystone - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/338/head:pull/338
$ git checkout pull/338

Update a local copy of the PR:
$ git checkout pull/338
$ git pull https://git.openjdk.java.net/jmc pull/338/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 338

View PR using the GUI difftool:
$ git pr show -t 338

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/338.diff

[bridgekeeper]

👋 Welcome back jpbempel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (edcb96d7)
• 00: Full (749158b4)

[thegreystone]

Do we want to keep the ability to open on the right page?

[jpbempel]

Do we want to keep the ability to open on the right page?

Yes, as long as the recording is still open, we navigate back to the specific previous page.
However when it's closed, the navigation can only reopen the recording and land on the default page.

[openjdk]

@jpbempel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7463: JfrEditor instances are kept in memory by NavigationHistory

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• d4449ce: 7439: Introduced IConstantPoolExtension for Constant Pools
• ca20442: 7198: Add websocket server that pushes data on selection updates
• 4d1c087: 7247: Alternate for Twitter4J to support twitter plug-in

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jpbempel]

/integrate

[openjdk]

Going to push as commit 8b8aa7c.
Since your change was applied there have been 3 commits pushed to the master branch:

• d4449ce: 7439: Introduced IConstantPoolExtension for Constant Pools
• ca20442: 7198: Add websocket server that pushes data on selection updates
• 4d1c087: 7247: Alternate for Twitter4J to support twitter plug-in

Your commit was automatically rebased without conflicts.

[openjdk]

@jpbempel Pushed as commit 8b8aa7c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.