Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7456: Remove the JDK 8 Eclipse launchers #339

Closed
wants to merge 1 commit into from
Closed

Conversation

aptmac
Copy link
Member

@aptmac aptmac commented Dec 3, 2021

This PR addresses JMC-7456 [0], in which the JDK-8 Eclipse launchers should be removed due to their incompatibility with Eclipse (as of 2020-09).

[0] https://bugs.openjdk.java.net/browse/JMC-7456


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7456: Remove the JDK 8 Eclipse launchers

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/339/head:pull/339
$ git checkout pull/339

Update a local copy of the PR:
$ git checkout pull/339
$ git pull https://git.openjdk.java.net/jmc pull/339/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 339

View PR using the GUI difftool:
$ git pr show -t 339

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/339.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2021

👋 Welcome back aptmac! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 3, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 3, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 3, 2021

@aptmac This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7456: Remove the JDK 8 Eclipse launchers

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 3, 2021
@aptmac
Copy link
Member Author

aptmac commented Dec 3, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 3, 2021

Going to push as commit 787bf0a.

@openjdk openjdk bot closed this Dec 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 3, 2021
@openjdk
Copy link

openjdk bot commented Dec 3, 2021

@aptmac Pushed as commit 787bf0a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aptmac aptmac deleted the 7456 branch December 3, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants