Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6668: Move org.openjdk.jmc.jdp bundle from application to core #34

Closed
wants to merge 3 commits into from

Conversation

@jiekang
Copy link
Contributor

jiekang commented Jan 15, 2020

Addresses https://bugs.openjdk.java.net/browse/JMC-6668

No code changes were made.

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

JMC-6668: Move org.openjdk.jmc.jdp bundle from application to core

Approvers

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 15, 2020

👋 Welcome back jkang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added the rfr label Jan 15, 2020
@mlbridge
Copy link

mlbridge bot commented Jan 15, 2020

Webrevs

@Gunde
Gunde approved these changes Jan 16, 2020
Copy link

Gunde left a comment

Looks good to me!

@openjdk openjdk bot removed the rfr label Jan 16, 2020
@openjdk
Copy link

openjdk bot commented Jan 16, 2020

@jiekang This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

6668: Move org.openjdk.jmc.jdp bundle from application to core

Reviewed-by: hdafgard
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to do this manually, please merge master into your branch first.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@Gunde) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jan 16, 2020
@jiekang
Copy link
Contributor Author

jiekang commented Jan 16, 2020

/integrate

@openjdk openjdk bot added the sponsor label Jan 16, 2020
@openjdk
Copy link

openjdk bot commented Jan 16, 2020

@jiekang
Your change (at version 1de78af) is now ready to be sponsored by a Committer.

@Gunde
Copy link

Gunde commented Jan 16, 2020

/sponsor

@openjdk openjdk bot closed this Jan 16, 2020
@openjdk openjdk bot added integrated and removed sponsor ready labels Jan 16, 2020
@openjdk
Copy link

openjdk bot commented Jan 16, 2020

@Gunde @jiekang The following commits have been pushed to master since your change was applied:

  • f74caa8: 6549: Color flame chart based on package name

Your commit was automatically rebased without conflicts.

Pushed as commit 8790592.

@mlbridge
Copy link

mlbridge bot commented Jan 16, 2020

Mailing list message from Henrik Dafgård on jmc-dev:

Changeset: 8790592
Author: Jie Kang <jkang at openjdk.org>
Committer: Henrik Dafg?rd <hdafgard at openjdk.org>
Date: 2020-01-16 15:53:39 +0000
URL: https://git.openjdk.java.net/jmc/commit/87905922

6668: Move org.openjdk.jmc.jdp bundle from application to core

Reviewed-by: hdafgard

! application/coverage/pom.xml
- application/org.openjdk.jmc.jdp/build.properties
- application/org.openjdk.jmc.jdp/pom.xml
- application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/Discoverable.java
- application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/DiscoveryEvent.java
- application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/DiscoveryListener.java
- application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/JDPClient.java
- application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/PacketListener.java
- application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/PacketProcessor.java
- application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/Pruner.java
- application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/package-info.java
- application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/CodingException.java
- application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/Configuration.java
- application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/ConfigurationFactory.java
- application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/JDPPacket.java
- application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/JRockitJDPPacketDecoder.java
- application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/package-info.java
- application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/jmx/JMXDataKeys.java
! application/pom.xml
- application/tests/org.openjdk.jmc.jdp.test/build.properties
- application/tests/org.openjdk.jmc.jdp.test/pom.xml
- application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/AllTests.java
- application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/ClientTester.java
- application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/ServerTester.java
- application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/JDPClientTest.java
- application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/JDPJMXTest.java
- application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/JDPPacketTest.java
- application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/JDPServerTest.java
- application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/TestToolkit.java
- application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/Broadcaster.java
- application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/JDPServer.java
- application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/jmx/JMXJDPServer.java
- application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/jmx/PIDHelper.java
- application/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/jmx/package-info.java
! application/tests/pom.xml
! core/coverage/pom.xml
= core/org.openjdk.jmc.jdp/.classpath
= core/org.openjdk.jmc.jdp/.project
= core/org.openjdk.jmc.jdp/.settings/org.eclipse.jdt.core.prefs
= core/org.openjdk.jmc.jdp/META-INF/MANIFEST.MF
+ core/org.openjdk.jmc.jdp/build.properties
+ core/org.openjdk.jmc.jdp/pom.xml
+ core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/Discoverable.java
+ core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/DiscoveryEvent.java
+ core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/DiscoveryListener.java
+ core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/JDPClient.java
+ core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/PacketListener.java
+ core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/PacketProcessor.java
+ core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/Pruner.java
+ core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/client/package-info.java
+ core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/CodingException.java
+ core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/Configuration.java
+ core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/ConfigurationFactory.java
+ core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/JDPPacket.java
+ core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/JRockitJDPPacketDecoder.java
+ core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/package-info.java
+ core/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/jmx/JMXDataKeys.java
! core/pom.xml
= core/tests/org.openjdk.jmc.jdp.test/.classpath
= core/tests/org.openjdk.jmc.jdp.test/.project
= core/tests/org.openjdk.jmc.jdp.test/META-INF/MANIFEST.MF
+ core/tests/org.openjdk.jmc.jdp.test/build.properties
+ core/tests/org.openjdk.jmc.jdp.test/pom.xml
+ core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/AllTests.java
+ core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/ClientTester.java
+ core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/ServerTester.java
+ core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/JDPClientTest.java
+ core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/JDPJMXTest.java
+ core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/JDPPacketTest.java
+ core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/JDPServerTest.java
+ core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/client/TestToolkit.java
+ core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/Broadcaster.java
+ core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/JDPServer.java
+ core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/jmx/JMXJDPServer.java
+ core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/jmx/PIDHelper.java
+ core/tests/org.openjdk.jmc.jdp.test/src/test/java/org/openjdk/jmc/jdp/server/jmx/package-info.java
! core/tests/pom.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.