Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7468: Fix jdp test coverage #340

Closed
wants to merge 1 commit into from

Conversation

aptmac
Copy link
Member

@aptmac aptmac commented Dec 3, 2021

This PR addresses JMC-7468 [0], in which the jdp test coverage is not added to the core coverage report.

The one-liner fix here is to make sure the argLine used by Jacoco is not overwritten by the surefire-plugin in the jdp.test pom.

Before (0%):
2021-12-03-141742_1091x251_scrot

After (60%):
2021-12-03-144244_1092x258_scrot

[0] https://bugs.openjdk.java.net/browse/JMC-7468


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/340/head:pull/340
$ git checkout pull/340

Update a local copy of the PR:
$ git checkout pull/340
$ git pull https://git.openjdk.java.net/jmc pull/340/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 340

View PR using the GUI difftool:
$ git pr show -t 340

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/340.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2021

👋 Welcome back aptmac! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@aptmac aptmac changed the title XXXX: Fix jdp test coverage 7468: Fix jdp test coverage Dec 3, 2021
@aptmac aptmac force-pushed the fix-jdp-test-coverage branch from aaaf4ac to cb9d21d Compare December 3, 2021 19:55
@openjdk openjdk bot added the rfr label Dec 3, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 3, 2021

Webrevs

@aptmac
Copy link
Member Author

aptmac commented Dec 3, 2021

Hm, it looks like the Windows validate action isn't having a good time at the moment, I'll re-run the checks later to see if that's the problem.

 win
The hosted runner: Hosted Agent lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error.

@openjdk
Copy link

openjdk bot commented Dec 3, 2021

@aptmac This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7468: Fix jdp test coverage

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 787bf0a: 7456: Remove the JDK 8 Eclipse launchers

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 3, 2021
@thegreystone thegreystone self-requested a review December 3, 2021 21:02
@aptmac
Copy link
Member Author

aptmac commented Dec 6, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 6, 2021

Going to push as commit 9148435.
Since your change was applied there have been 2 commits pushed to the master branch:

  • ba365fb: 7451: Add heat map view
  • 787bf0a: 7456: Remove the JDK 8 Eclipse launchers

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Dec 6, 2021
@openjdk
Copy link

openjdk bot commented Dec 6, 2021

@aptmac Pushed as commit 9148435.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aptmac aptmac deleted the fix-jdp-test-coverage branch May 18, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants