-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7468: Fix jdp test coverage #340
Conversation
👋 Welcome back aptmac! A progress list of the required criteria for merging this PR into |
aaaf4ac
to
cb9d21d
Compare
Hm, it looks like the Windows validate action isn't having a good time at the moment, I'll re-run the checks later to see if that's the problem.
|
@aptmac This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
This PR addresses JMC-7468 [0], in which the jdp test coverage is not added to the core coverage report.
The one-liner fix here is to make sure the argLine used by Jacoco is not overwritten by the surefire-plugin in the jdp.test pom.
Before (0%):
After (60%):
[0] https://bugs.openjdk.java.net/browse/JMC-7468
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/340/head:pull/340
$ git checkout pull/340
Update a local copy of the PR:
$ git checkout pull/340
$ git pull https://git.openjdk.java.net/jmc pull/340/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 340
View PR using the GUI difftool:
$ git pr show -t 340
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/340.diff