7480: Trim method descriptor value

[gunnarmorling]

Hey @thegreystone, here's a fix for trimming the method signature value when building the method descriptors in the agent. Without this, wrapping the tags around long signatures like that will fail:

 <descriptor>
   (Ljava/sql/PreparedStatement;Ljava/lang/Object;ILorg/hibernate/type/descriptor/WrapperOptions;)V
</descriptor>

Could you log an issue if you think it's a worthwhile fix? The second commit is some unrelated clean-up I did along the way. Thx!

---

Progress

• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JMC-7480: Trim method descriptor value

Reviewers

• Marcus Hirt (@thegreystone - Reviewer) ⚠️ Review applies to dcf167d

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/343/head:pull/343
$ git checkout pull/343

Update a local copy of the PR:
$ git checkout pull/343
$ git pull https://git.openjdk.java.net/jmc pull/343/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 343

View PR using the GUI difftool:
$ git pr show -t 343

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/343.diff

[bridgekeeper]

👋 Welcome back gunnarmorling! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (9243d98b)
• 00: Full (dcf167d0)

[openjdk]

@gunnarmorling This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7480: Trim method descriptor value

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[gunnarmorling]

@thegreystone thx for logging 7480. Reworded the commit messages accordingly.

[gunnarmorling]

/integrate

[openjdk]

@gunnarmorling
Your change (at version 9243d98) is now ready to be sponsored by a Committer.

[thegreystone]

/sponsor

[openjdk]

Going to push as commit 1c6ccc9.

[openjdk]

@thegreystone @gunnarmorling Pushed as commit 1c6ccc9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.