Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7482: Confusing display of stack traces when selecting event types with no events #344

Closed
wants to merge 1 commit into from

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Dec 29, 2021

…th no events

In EventBrowser page, when there is no selection all events are
considered but if there is a selection we filtered events based on
this selection event if there is no events


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7482: Confusing display of stack traces when selecting event types with no events

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/344/head:pull/344
$ git checkout pull/344

Update a local copy of the PR:
$ git checkout pull/344
$ git pull https://git.openjdk.java.net/jmc pull/344/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 344

View PR using the GUI difftool:
$ git pr show -t 344

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/344.diff

…th no events

In EventBrowser page, when there is no selection all events are
considered but if there is a selection we filtered events based on
this selection event if there is no events
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 29, 2021

👋 Welcome back jpbempel! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 7482: Confusing display of stack traces when selecting event types wi… 7482: Confusing display of stack traces when selecting event types with no events Dec 29, 2021
@openjdk openjdk bot added the rfr label Dec 29, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 29, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 10, 2022

@jpbempel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7482: Confusing display of stack traces when selecting event types with no events

Reviewed-by: aptmac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • f077a40: 7493: Update versions and copyright on Update site pages

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 10, 2022
@thegreystone
Copy link
Member

@jpbempel - this is ready to integrate - @aptmac is a reviewer now. :)

@jpbempel
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2022

Going to push as commit ce10e3f.
Since your change was applied there have been 2 commits pushed to the master branch:

  • b65e351: 7494: Unable to view JMC Help Contents
  • f077a40: 7493: Update versions and copyright on Update site pages

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 10, 2022
@openjdk openjdk bot closed this Jan 10, 2022
@openjdk
Copy link

openjdk bot commented Jan 10, 2022

@jpbempel Pushed as commit ce10e3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants