Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7492: Update org.owasp.encoder to version 1.2.3 #345

Closed
wants to merge 3 commits into from

Conversation

bhopatil
Copy link
Contributor

@bhopatil bhopatil commented Jan 3, 2022


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7492: Update org.owasp.encoder to version 1.2.3

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/345/head:pull/345
$ git checkout pull/345

Update a local copy of the PR:
$ git checkout pull/345
$ git pull https://git.openjdk.java.net/jmc pull/345/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 345

View PR using the GUI difftool:
$ git pr show -t 345

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/345.diff

@bridgekeeper bridgekeeper bot added the oca label Jan 3, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 3, 2022

Hi @bhopatil, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user bhopatil" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Jan 3, 2022

⚠️ @bhopatil This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@thegreystone thegreystone changed the title 7492: Updated org.owasp.encoder to 1.2.3 7492: Update org.owasp.encoder to version 1.2.3 Jan 5, 2022
@bhopatil
Copy link
Contributor Author

bhopatil commented Jan 6, 2022

/covered

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 6, 2022

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@bhopatil bhopatil marked this pull request as draft January 6, 2022 06:17
@bhopatil bhopatil marked this pull request as ready for review January 13, 2022 05:50
@openjdk openjdk bot added the rfr label Jan 13, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 13, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 13, 2022

@bhopatil This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7492: Update org.owasp.encoder to version 1.2.3

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 70aa834: 7505: Cannot reset websocket server port to default
  • be067ab: 7504: Fix flightrecorder.writer.test project setup
  • dbb3e76: 7473: Unable to view constants in constant pool page.
  • b6bf40f: 7485: JMC Application, Plugins and License Copyright year requires update
  • 367914b: 7503: Fix serializers.test dependency
  • ce10e3f: 7482: Confusing display of stack traces when selecting event types with no events
  • b65e351: 7494: Unable to view JMC Help Contents
  • f077a40: 7493: Update versions and copyright on Update site pages

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jan 13, 2022
@bhopatil
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor label Jan 13, 2022
@openjdk
Copy link

openjdk bot commented Jan 13, 2022

@bhopatil
Your change (at version acdab7e) is now ready to be sponsored by a Committer.

@thegreystone
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 13, 2022

Going to push as commit 132d281.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 70aa834: 7505: Cannot reset websocket server port to default
  • be067ab: 7504: Fix flightrecorder.writer.test project setup
  • dbb3e76: 7473: Unable to view constants in constant pool page.
  • b6bf40f: 7485: JMC Application, Plugins and License Copyright year requires update
  • 367914b: 7503: Fix serializers.test dependency
  • ce10e3f: 7482: Confusing display of stack traces when selecting event types with no events
  • b65e351: 7494: Unable to view JMC Help Contents
  • f077a40: 7493: Update versions and copyright on Update site pages

Your commit was automatically rebased without conflicts.

@openjdk
Copy link

openjdk bot commented Jan 13, 2022

@thegreystone @bhopatil Pushed as commit 132d281.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants