Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7493: Update versions and copyright on Update site pages #346

Closed
wants to merge 2 commits into from

Conversation

Suchitainf
Copy link
Collaborator

@Suchitainf Suchitainf commented Jan 5, 2022

This PR updates the copyright year and Eclipse pre-requisite version.


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7493: Update versions and copyright on Update site pages

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/346/head:pull/346
$ git checkout pull/346

Update a local copy of the PR:
$ git checkout pull/346
$ git pull https://git.openjdk.java.net/jmc pull/346/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 346

View PR using the GUI difftool:
$ git pr show -t 346

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/346.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2022

👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 5, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@Suchitainf This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7493: Update versions and copyright on Update site pages

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 5, 2022
@Suchitainf
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 5, 2022

Going to push as commit f077a40.

@openjdk openjdk bot added the integrated label Jan 5, 2022
@aptmac
Copy link
Member

aptmac commented Jan 14, 2022

Neat, looks like the bot didn't close this close this PR after integrating it. It should be closed now I believe.

@thegreystone
Copy link
Member

@edvbld - do you know what might have happened here?

@thegreystone
Copy link
Member

@openjdk openjdk bot closed this Jan 21, 2022
@openjdk
Copy link

openjdk bot commented Jan 21, 2022

@Suchitainf Pushed as commit f077a40.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants