-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7473: Unable to view constants in constant pool page. #348
Conversation
👋 Welcome back aptmac! A progress list of the required criteria for merging this PR into |
@aptmac This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit dbb3e76.
Your commit was automatically rebased without conflicts. |
This PR addresses JMC-7473 [0], in which the Constant Pools page throws an exception and does not display. The issue here is in ParserStats, and happens if the stacktrace object doesn't have any frames - but there is a retrieval for the first frame.
Before:
After:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/348/head:pull/348
$ git checkout pull/348
Update a local copy of the PR:
$ git checkout pull/348
$ git pull https://git.openjdk.java.net/jmc pull/348/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 348
View PR using the GUI difftool:
$ git pr show -t 348
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/348.diff