Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7473: Unable to view constants in constant pool page. #348

Closed
wants to merge 2 commits into from

Conversation

aptmac
Copy link
Member

@aptmac aptmac commented Jan 10, 2022

This PR addresses JMC-7473 [0], in which the Constant Pools page throws an exception and does not display. The issue here is in ParserStats, and happens if the stacktrace object doesn't have any frames - but there is a retrieval for the first frame.

Before:
2022-01-10-105031_790x151_scrot

After:
2022-01-10-105044_668x458_scrot


Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7473: Unable to view constants in constant pool page.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/348/head:pull/348
$ git checkout pull/348

Update a local copy of the PR:
$ git checkout pull/348
$ git pull https://git.openjdk.java.net/jmc pull/348/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 348

View PR using the GUI difftool:
$ git pr show -t 348

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/348.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2022

👋 Welcome back aptmac! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 7473: Unable to view constants in constant pool page 7473: Unable to view constants in constant pool page. Jan 10, 2022
@openjdk openjdk bot added the rfr label Jan 10, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 10, 2022

Webrevs

@thegreystone thegreystone requested a review from jpbempel Jan 10, 2022
@openjdk
Copy link

openjdk bot commented Jan 10, 2022

@aptmac This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7473: Unable to view constants in constant pool page.

Reviewed-by: jpbempel, hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • ce10e3f: 7482: Confusing display of stack traces when selecting event types with no events
  • b65e351: 7494: Unable to view JMC Help Contents
  • f077a40: 7493: Update versions and copyright on Update site pages

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 10, 2022
@aptmac
Copy link
Member Author

aptmac commented Jan 12, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 12, 2022

Going to push as commit dbb3e76.
Since your change was applied there have been 5 commits pushed to the master branch:

  • b6bf40f: 7485: JMC Application, Plugins and License Copyright year requires update
  • 367914b: 7503: Fix serializers.test dependency
  • ce10e3f: 7482: Confusing display of stack traces when selecting event types with no events
  • b65e351: 7494: Unable to view JMC Help Contents
  • f077a40: 7493: Update versions and copyright on Update site pages

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 12, 2022
@openjdk openjdk bot closed this Jan 12, 2022
@openjdk
Copy link

openjdk bot commented Jan 12, 2022

@aptmac Pushed as commit dbb3e76.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants