Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7485: JMC Application, Plugins and License Copyright year requires update #350

Closed
wants to merge 2 commits into from
Closed

7485: JMC Application, Plugins and License Copyright year requires update #350

wants to merge 2 commits into from

Conversation

Suchitainf
Copy link
Collaborator

@Suchitainf Suchitainf commented Jan 11, 2022 •
edited by openjdk bot
Loading

This PR addresses the copyright update task for JMC 8.2 release.

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JMC-7485: JMC Application, Plugins and License Copyright year requires update

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jmc pull/350/head:pull/350
$ git checkout pull/350

Update a local copy of the PR:
$ git checkout pull/350
$ git pull https://git.openjdk.java.net/jmc pull/350/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 350

View PR using the GUI difftool:
$ git pr show -t 350

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jmc/pull/350.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2022

👋 Welcome back schaturvedi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 11, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 11, 2022 •
edited
Loading

Webrevs

thegreystone
thegreystone requested changes Jan 12, 2022
View reviewed changes
application/org.openjdk.jmc.browser.jdp/plugin.properties Outdated
@@ -1,5 +1,5 @@
#
# Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
# Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file didn't change, hence the copyright year should not change.

application/org.openjdk.jmc.browser/plugin.properties Outdated
@@ -1,5 +1,5 @@
#
# Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
# Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file didn't change, hence the copyright year should not change.

application/org.openjdk.jmc.console.ui.mbeanbrowser/plugin.properties Outdated
@@ -1,5 +1,5 @@
#
# Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
# Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file didn't change, hence the copyright year should not change.

application/org.openjdk.jmc.console.ui.notification/plugin.properties Outdated
@@ -1,5 +1,5 @@
#
# Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
# Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file didn't change, hence the copyright year should not change.

application/org.openjdk.jmc.console.ui.subscriptions/plugin.properties Outdated
@@ -1,5 +1,5 @@
#
# Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
# Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file didn't change, hence the copyright year should not change.

application/org.openjdk.jmc.ide.ui/html/using004.htm
@@ -1,7 +1,7 @@
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<!--
Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright should change further down in the file (to be a range).

application/org.openjdk.jmc.ide.ui/html/using005.htm
@@ -1,7 +1,7 @@
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<!--
Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright should change further down in the file (to be a range).

application/org.openjdk.jmc.ide.ui/html/using006.htm
@@ -1,7 +1,7 @@
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<!--
Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright should change further down in the file (to be a range).

application/org.openjdk.jmc.ide.ui/html/using007.htm
@@ -1,7 +1,7 @@
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<!--
Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright should change further down in the file (to be a range).

application/org.openjdk.jmc.rcp.intro/plugin.properties Outdated
@@ -1,5 +1,5 @@
#
# Copyright (c) 2018, 2021, Oracle and/or its affiliates. All rights reserved.
# Copyright (c) 2018, 2022, Oracle and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File not changed - don't change copyright.

@openjdk
Copy link

openjdk bot commented Jan 12, 2022

@Suchitainf This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7485: JMC Application, Plugins and License Copyright year requires update

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • ce10e3f: 7482: Confusing display of stack traces when selecting event types with no events
  • b65e351: 7494: Unable to view JMC Help Contents

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 12, 2022
@Suchitainf
Copy link
Collaborator Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 12, 2022

Going to push as commit b6bf40f.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 367914b: 7503: Fix serializers.test dependency
  • ce10e3f: 7482: Confusing display of stack traces when selecting event types with no events
  • b65e351: 7494: Unable to view JMC Help Contents

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 12, 2022
@openjdk openjdk bot closed this Jan 12, 2022
@openjdk
Copy link

openjdk bot commented Jan 12, 2022

@Suchitainf Pushed as commit b6bf40f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thegreystone thegreystone thegreystone approved these changes

Assignees
No one assigned
Labels
integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Suchitainf @thegreystone